test: add test case

[facetosea]

Description

Please briefly describe the code changes in this pull request.

Jira: https://jira.taosdata.com:18080/browse/TD-

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @facetosea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the test coverage for several time-series window functions, including INTERVAL, STATE_WINDOW, EVENT_WINDOW, SESSION, and COUNT_WINDOW. The added tests explore a broader range of query structures, such as selecting non-aggregate columns and constants, and specific windowing conditions. A notable change in the parser involves commenting out a syntax validation for window functions lacking aggregate functions or state keys, which directly supports the expanded testing scope and potentially new feature capabilities.

Highlights

• Parser Modification: A syntax check preventing window functions without aggregate functions or state keys has been commented out in parTranslater.c, potentially enabling new query patterns.
• Interval Window Tests: New test cases for INTERVAL window functions have been added, specifically validating queries that select non-aggregate columns alongside window metadata.
• State Window Enhancements: Expanded tests for STATE_WINDOW now cover scenarios involving null values at the window start and diverse column selections.
• Event Window Coverage: Additional test queries for EVENT_WINDOW have been introduced, focusing on _wstart, _wend, and constant projections with slimit and limit.
• Session Window Validation: Comprehensive tests for SESSION window functions have been added, examining behavior with and without aggregate functions, and in conjunction with partition by clauses.
• Count Window Scenarios: New test cases for COUNT_WINDOW validate various column selections, aggregate functions, and partition by usage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables window queries without requiring aggregate functions, a valuable feature enhancement. The core logic change in parTranslater.c is well-supported by a comprehensive suite of new test cases for various window types.

My review primarily focuses on improving code maintainability and style. I've suggested removing commented-out code in the C source file. For the Python test files, my recommendations include removing unused variables, adopting more idiomatic Python loops, ensuring consistent SQL query formatting, and refactoring duplicated test logic to improve readability and ease of maintenance.

Overall, the changes are solid and the tests are thorough. Addressing these minor points will further enhance the quality of the codebase.

[gemini-code-assist]

This block of code is commented out. If it's no longer needed, it should be removed to improve code clarity. Leaving dead code can be confusing for future maintenance.

[gemini-code-assist]

The variable totalNum is defined but never used. It should be removed to avoid confusion and improve code clarity.

[gemini-code-assist]

For better readability and to follow Python best practices, these while loops with manual incrementing can be replaced with for loops using range().

Suggested change

	i = 0
	while i < tbNum:
	tb = tbPrefix + str(i)
	tdSql.execute(f"create table {tb} using {mt} tags( {i} )")
	x = 0
	while x < rowNum:
	cc = x * 60000
	ms = 1601481600000 + cc
	tdSql.execute(f"insert into {tb} values ({ms} , {x} )")
	x = x + 1
	i = i + 1
	for i in range(tbNum):
	tb = tbPrefix + str(i)
	tdSql.execute(f"create table {tb} using {mt} tags( {i} )")
	for x in range(rowNum):
	cc = x * 60000
	ms = 1601481600000 + cc
	tdSql.execute(f"insert into {tb} values ({ms} , {x} )")

[gemini-code-assist]

There's an inconsistent use of trailing semicolons in the SQL queries within this block. For consistency with the rest of the file and general Python practice for single-statement strings, it's better to remove them.

[gemini-code-assist]

This line has trailing whitespace, which should be removed to maintain code style consistency.

Suggested change

	tdSql.checkData(3, 3, "b")
	tdSql.checkData(3, 3, "b")

[gemini-code-assist]

The file should end with a newline character. This is a common convention to prevent issues with file concatenation and some tools.

Suggested change

[gemini-code-assist]

The test logic for queries with and without count(*) is very similar, leading to significant code duplication. Consider refactoring this into a helper function to improve readability and maintainability. The function could take the select clause as an argument and perform the common checks.

[gemini-code-assist]

Similar to the previous section, these two test blocks for queries with and without count(*) on a partitioned table are highly repetitive. A helper function could abstract the common setup and assertions, making the test code more concise and easier to maintain.

[gemini-code-assist]

This line contains unnecessary whitespace. It should be removed to maintain a clean code style.

[gemini-code-assist]

Some SQL queries in this block end with a semicolon, while others do not. For consistency, it's recommended to remove the trailing semicolons from all queries.