-
Notifications
You must be signed in to change notification settings - Fork 5k
feat(tmq): [TS-6379]remove limition for table operation in tmq #33726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @wangmm0220, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the flexibility of TMQ by lifting restrictions on table operations when topics are active. It achieves this by overhauling the internal schema management and validation mechanisms, ensuring that schema information is directly integrated into the data processing pipeline and consistently provided to consumers. The changes simplify the codebase and enhance the system's adaptability to schema changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes limitations on table operations for tables used in TMQ topics, which is a significant feature enhancement. The changes are extensive, involving refactoring of schema handling in TMQ messages and removing restrictive checks in both mnode and vnode. While the overall direction is good, I've identified a critical backward compatibility issue that could impact upgrades, along with two high-severity memory leaks related to schema management in the topic lifecycle. I've provided detailed comments and code suggestions to address these issues. Please review them carefully before merging.
Description
Please briefly describe the code changes in this pull request.
Jira: https://jira.taosdata.com:18080/browse/TD-
Checklist
Please check the items in the checklist if applicable.