Ensure that the VNFunc for HWIntrinsics are properly marked as commutative where possible (dotnet#75840)

tannergooding · web-flow · commit a9c08d493c46 · 2022-09-20T12:48:55.000-07:00
diff --git a/src/coreclr/jit/valuenum.cpp b/src/coreclr/jit/valuenum.cpp
@@ -7049,6 +7049,12 @@ void ValueNumStore::InitValueNumStoreStatics()
 
             ValueNumFuncSetArity(func, newArity);
         }
+
+        if (HWIntrinsicInfo::IsCommutative(id))
+        {
+            VNFunc func = VNFunc(VNF_HWI_FIRST + (id - NI_HW_INTRINSIC_START - 1));
+            vnfOpAttribs[func] |= VNFOA_Commutative;
+        }
     }
 
 #endif // FEATURE_HW_INTRINSICS

Original file line number	Diff line number	Diff line change
`@@ -7049,6 +7049,12 @@ void ValueNumStore::InitValueNumStoreStatics()`
`7049`	`7049`
`7050`	`7050`	`ValueNumFuncSetArity(func, newArity);`
`7051`	`7051`	`}`
	`7052`	`+`
	`7053`	`+ if (HWIntrinsicInfo::IsCommutative(id))`
	`7054`	`+ {`
	`7055`	`+ VNFunc func = VNFunc(VNF_HWI_FIRST + (id - NI_HW_INTRINSIC_START - 1));`
	`7056`	`+ vnfOpAttribs[func] \|= VNFOA_Commutative;`
	`7057`	`+ }`
`7052`	`7058`	`}`
`7053`	`7059`
`7054`	`7060`	`#endif // FEATURE_HW_INTRINSICS`