Skip to content

Commit 5f3199e

Browse files
committed
[core] Improve error message when GNU tar is missing
This has led to numerous reported issues in the past. Spacemacs can work without GNU tar, because quelpa installation only fails for some packages; so it should suffice to add the message in that case. Also, remove the superfluous quote from the condition name error.
1 parent ccd3e20 commit 5f3199e

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

core/core-configuration-layer.el

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1717,9 +1717,14 @@ RNAME is the name symbol of another existing layer."
17171717
(oset pkg lazy-install nil))
17181718
(t (configuration-layer//warning "Cannot install package %S."
17191719
pkg-name)))
1720-
('error
1720+
(error
17211721
(configuration-layer//error
1722-
(concat "\nAn error occurred while installing %s " "(error: %s)\n")
1722+
(concat "An error occurred while installing %s " "(error: %s)"
1723+
(when (and (equal err '(wrong-type-argument package-desc nil))
1724+
(boundp 'quelpa--tar-type)
1725+
(eq quelpa--tar-type 'bsd))
1726+
". It looks like GNU tar is not installed, or `quelpa-build-tar-executable' \
1727+
needs to be customized to a GNU tar executable."))
17231728
pkg-name
17241729
err)
17251730
(spacemacs//redisplay))))))

0 commit comments

Comments
 (0)