fix!: rename option isolatedDeclaration to isolatedDeclarations (#15)

Co-authored-by: 三咲智子 Kevin Deng <[email protected]>

Author: ocavue

README.md

@@ -68,7 +68,9 @@ interface Options {
    *
    * This option is enabled when `isolatedDeclarations` in `compilerOptions` is set to `true`.
    */
-  isolatedDeclaration?: boolean | Omit<IsolatedDeclarationsOptions, 'sourcemap'>
+  isolatedDeclarations?:
+    | boolean
+    | Omit<IsolatedDeclarationsOptions, 'sourcemap'>
 
   /** Resolve external types used in dts files from `node_modules` */
   resolve?: boolean | (string | RegExp)[]
@@ -79,7 +81,7 @@ interface Options {
 
 ### Isolated Declarations
 
-The plugin leverages Oxc's `isolatedDeclarations` to generate `.d.ts` files when `isolatedDeclaration` is enabled,
+The plugin leverages Oxc's `isolatedDeclarations` to generate `.d.ts` files when `isolatedDeclarations` is enabled,
 offering significantly faster performance compared to the `typescript` compiler.
 
 ### Single Build for ESM

src/generate.ts

@@ -31,12 +31,12 @@ export type DtsMap = Map<string, TsModule>
 export function createGeneratePlugin({
   tsconfig,
   compilerOptions,
-  isolatedDeclaration,
+  isolatedDeclarations,
   resolve = false,
   emitDtsOnly = false,
 }: Pick<
   Options,
-  | 'isolatedDeclaration'
+  | 'isolatedDeclarations'
   | 'resolve'
   | 'emitDtsOnly'
   | 'tsconfig'
@@ -60,14 +60,14 @@ export function createGeneratePlugin({
       }
     }
 
-    if (isolatedDeclaration == null) {
-      isolatedDeclaration = !!compilerOptions?.isolatedDeclarations
+    if (isolatedDeclarations == null) {
+      isolatedDeclarations = !!compilerOptions?.isolatedDeclarations
     }
-    if (isolatedDeclaration === true) {
-      isolatedDeclaration = {}
+    if (isolatedDeclarations === true) {
+      isolatedDeclarations = {}
     }
-    if (isolatedDeclaration && isolatedDeclaration.stripInternal == null) {
-      isolatedDeclaration.stripInternal = !!compilerOptions?.stripInternal
+    if (isolatedDeclarations && isolatedDeclarations.stripInternal == null) {
+      isolatedDeclarations.stripInternal = !!compilerOptions?.stripInternal
     }
   }
 
@@ -93,7 +93,7 @@ export function createGeneratePlugin({
         tsconfig: tsconfig ? (tsconfig as string) : undefined,
       })
 
-      if (!isolatedDeclaration) {
+      if (!isolatedDeclarations) {
         initTs()
       }
 
@@ -245,11 +245,11 @@ export function createGeneratePlugin({
         const { code, id, isEntry } = dtsMap.get(dtsId)!
         let dtsCode: string | undefined
 
-        if (isolatedDeclaration) {
+        if (isolatedDeclarations) {
           const result = oxcIsolatedDeclaration(
             id,
             code,
-            isolatedDeclaration === true ? {} : isolatedDeclaration,
+            isolatedDeclarations === true ? {} : isolatedDeclarations,
           )
           if (result.errors.length) {
             const [error] = result.errors

src/index.ts

@@ -42,7 +42,9 @@ export interface Options {
    *
    * This option is enabled when `isolatedDeclarations` in `compilerOptions` is set to `true`.
    */
-  isolatedDeclaration?: boolean | Omit<IsolatedDeclarationsOptions, 'sourcemap'>
+  isolatedDeclarations?:
+    | boolean
+    | Omit<IsolatedDeclarationsOptions, 'sourcemap'>
 
   /** Resolve external types used in dts files from `node_modules` */
   resolve?: boolean | (string | RegExp)[]

tests/index.test.ts

@@ -42,7 +42,7 @@ test('typescript compiler', async () => {
           skipLibCheck: true,
           isolatedDeclarations: false,
         },
-        isolatedDeclaration: false,
+        isolatedDeclarations: false,
       }),
     ],
   )
@@ -55,7 +55,7 @@ test('resolve dependencies', async () => {
     [
       dts({
         resolve: ['magic-string-ast'],
-        isolatedDeclaration: true,
+        isolatedDeclarations: true,
         emitDtsOnly: true,
       }),
     ],
@@ -73,7 +73,7 @@ test('input alias', async () => {
       dts({
         emitDtsOnly: false, // Generate both JS and DTS files
         compilerOptions: {},
-        isolatedDeclaration: false,
+        isolatedDeclarations: false,
       }),
     ],
     {
@@ -103,7 +103,7 @@ test('isolated declaration error', async () => {
     [
       dts({
         emitDtsOnly: true,
-        isolatedDeclaration: true,
+        isolatedDeclarations: true,
       }),
     ],
   ).catch((error: any) => error)
@@ -119,7 +119,7 @@ test('paths', async () => {
     path.resolve(root, 'index.ts'),
     [
       dts({
-        isolatedDeclaration: true,
+        isolatedDeclarations: true,
         emitDtsOnly: true,
       }),
     ],

tsdown.config.ts

@@ -8,7 +8,7 @@ export default defineConfig({
   platform: 'node',
   plugins: [
     dts({
-      isolatedDeclaration: true,
+      isolatedDeclarations: true,
     }),
   ],
 })