Skip to content

Remove overload #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Remove overload #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acb6de5
Added minimum iOS target
btoms20 Sep 14, 2022
f2a49db
Merge remote-tracking branch 'refs/remotes/origin/main'
btoms20 Sep 14, 2022
588b33f
Removed the ipfs p2p overload.
btoms20 Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tests/CIDTests/CIDTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,9 @@ final class CIDTests: XCTestCase {
XCTAssertEqual(cid1.multihash, cid2.multihash)
XCTAssertEqual(cid1.multibase, cid2.multibase)

/// P2P and IPFS Interop (Name is different, code is the same (should result in the same hash))
/// P2P =/= IPFS Interop (Name is different, code is different)
XCTAssertNotEqual(cid1.codec, cid3.codec) // .ipfs != .p2p
XCTAssertEqual(cid1.code, cid3.code) // 0x01a5 == 0x01a5
XCTAssertNotEqual(cid1.code, cid3.code) // 0x01a5 == 0x01a5
XCTAssertEqual(cid1.version, cid3.version)
XCTAssertEqual(cid1.multihash, cid3.multihash)
XCTAssertEqual(cid1.multibase, cid3.multibase)
Expand Down