Skip to content

Commit 8319c0f

Browse files
authored
enable useGOMEMLIMIT by default (open-telemetry#977)
1 parent 87f0437 commit 8319c0f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+73
-87
lines changed

charts/opentelemetry-collector/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: v2
22
name: opentelemetry-collector
3-
version: 0.75.1
3+
version: 0.76.0
44
description: OpenTelemetry Collector Helm chart for Kubernetes
55
type: application
66
home: https://opentelemetry.io/

charts/opentelemetry-collector/UPGRADING.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,15 @@ When enabled, the chart will remove the Memory Ballast Extension from the collec
1313
of the configured `resources.limits.memory`. If no `resources.limits.memory` are set when `useGOMEMLIMIT` is enabled then a `GOMEMLIMIT` environment variable WILL NOT be
1414
created but the Memory Ballast Extension will still be removed.
1515

16-
If you are not interested in using `GOMEMLIMIT` then this change does not affect you. But, depending on the progress made in [Issue 891](https://github.com/open-telemetry/opentelemetry-helm-charts/issues/891),
16+
Depending on the progress made in [Issue 891](https://github.com/open-telemetry/opentelemetry-helm-charts/issues/891),
1717
the use of `GOMEMLIMIT` may completely replace the Memory Ballast Extension in the future.
1818

19+
## 0.75.1 to 0.76.0
20+
21+
Enable the `useGOMEMLIMIT` feature flag by default. This means by default the chart now does not use the Memory Ballast Extension and any custom configuraiton applied to the Memory Ballast Extension is ignored.
22+
23+
**If you're still interested in using the Memory Ballast Extension set this back to false.**
24+
1925
## 0.69.3 to 0.70.0
2026

2127
The following deprecated fields have been removed. Please use the new values:

charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered/configmap-agent.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector-agent
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"
@@ -23,8 +23,6 @@ data:
2323
insecure: true
2424
extensions:
2525
health_check: {}
26-
memory_ballast:
27-
size_in_percentage: 40
2826
processors:
2927
batch: {}
3028
memory_limiter:
@@ -59,7 +57,6 @@ data:
5957
service:
6058
extensions:
6159
- health_check
62-
- memory_ballast
6360
pipelines:
6461
logs:
6562
exporters:

charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered/configmap.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"
@@ -19,8 +19,6 @@ data:
1919
logging: {}
2020
extensions:
2121
health_check: {}
22-
memory_ballast:
23-
size_in_percentage: 40
2422
processors:
2523
batch: {}
2624
memory_limiter:
@@ -55,7 +53,6 @@ data:
5553
service:
5654
extensions:
5755
- health_check
58-
- memory_ballast
5956
pipelines:
6057
logs:
6158
exporters:

charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered/daemonset.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector-agent
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"
@@ -23,7 +23,7 @@ spec:
2323
template:
2424
metadata:
2525
annotations:
26-
checksum/config: 7db5356cd329e8be0446b54f6abcab3582243ab083bd876b72e80dfe42836d90
26+
checksum/config: 4c754e86e0042f7956dd1acd83596ff05e5a84d2cfad3843ae4a2c909c1af333
2727

2828
labels:
2929
app.kubernetes.io/name: opentelemetry-collector
@@ -76,6 +76,8 @@ spec:
7676
fieldRef:
7777
apiVersion: v1
7878
fieldPath: status.podIP
79+
- name: GOMEMLIMIT
80+
value: 156MiB
7981
livenessProbe:
8082
httpGet:
8183
path: /

charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered/deployment.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"
@@ -25,7 +25,7 @@ spec:
2525
template:
2626
metadata:
2727
annotations:
28-
checksum/config: 8973c991f2dfa7e12914f574c78f471061b1678a6285f2fce497cf8ac19325fe
28+
checksum/config: e9fb193dffb5840a0442a66c8346dabd78429ea7fa062208a650a62eac8a8179
2929

3030
labels:
3131
app.kubernetes.io/name: opentelemetry-collector
@@ -72,6 +72,8 @@ spec:
7272
fieldRef:
7373
apiVersion: v1
7474
fieldPath: status.podIP
75+
- name: GOMEMLIMIT
76+
value: 156MiB
7577
livenessProbe:
7678
httpGet:
7779
path: /

charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"

charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered/serviceaccount.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"

charts/opentelemetry-collector/examples/daemonset-collector-logs/rendered/configmap-agent.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector-agent
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"
@@ -19,8 +19,6 @@ data:
1919
logging: {}
2020
extensions:
2121
health_check: {}
22-
memory_ballast:
23-
size_in_percentage: 40
2422
processors:
2523
batch: {}
2624
memory_limiter:
@@ -132,7 +130,6 @@ data:
132130
service:
133131
extensions:
134132
- health_check
135-
- memory_ballast
136133
pipelines:
137134
logs:
138135
exporters:

charts/opentelemetry-collector/examples/daemonset-collector-logs/rendered/daemonset.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: example-opentelemetry-collector-agent
77
namespace: default
88
labels:
9-
helm.sh/chart: opentelemetry-collector-0.75.1
9+
helm.sh/chart: opentelemetry-collector-0.76.0
1010
app.kubernetes.io/name: opentelemetry-collector
1111
app.kubernetes.io/instance: example
1212
app.kubernetes.io/version: "0.90.1"
@@ -23,7 +23,7 @@ spec:
2323
template:
2424
metadata:
2525
annotations:
26-
checksum/config: 63c403e6abfb04b8ed9aef3b469405b4b79063e0913a09a057ae781ef1697842
26+
checksum/config: 3178578cb4ed0f580cb2a04d1b25cb1d139fc29b2a85a1faf51e58cc1fa44748
2727

2828
labels:
2929
app.kubernetes.io/name: opentelemetry-collector

0 commit comments

Comments
 (0)