chore: add tests

Author: cuyl

crates/swc_ecma_minifier/src/compress/pure/evaluate.rs

@@ -1181,17 +1181,27 @@ fn may_have_side_effects(args: &Vec<Option<ExprOrSpread>>, expr_ctx: &ExprCtx) -
 }
 
 fn get_first_arg(args: &Vec<Option<ExprOrSpread>>, expr_ctx: &ExprCtx) -> Option<Option<f64>> {
-    args.first().and_then(|arg| {
-        if let Some(arg) = arg {
-            if arg.spread.is_some() {
-                match arg.expr.as_array() {
-                    Some(args) => get_first_arg(&args.elems, expr_ctx),
-                    None => None,
-                };
-            } else if !arg.expr.is_undefined(*expr_ctx) {
-                return Some(eval_as_number(*expr_ctx, &arg.expr));
+    args.iter()
+        .find_map(|arg| {
+            if let Some(arg) = arg {
+                if arg.spread.is_some() {
+                    match arg.expr.as_array() {
+                        Some(args) => {
+                            if args.elems.is_empty() {
+                                // next argument is used if the first spread argument is empty
+                                // so we can't evaluate the call.
+                                return None;
+                            } else {
+                                Some(get_first_arg(&args.elems, expr_ctx))
+                            }
+                        }
+                        None => Some(None),
+                    };
+                } else if !arg.expr.is_undefined(*expr_ctx) {
+                    return Some(Some(eval_as_number(*expr_ctx, &arg.expr)));
+                }
             }
-        }
-        None
-    })
+            Some(None)
+        })
+        .unwrap_or(None)
 }

crates/swc_ecma_minifier/tests/terser/compress/evaluate/number_method_call/input.js

@@ -12,3 +12,8 @@ console.log((1.23).toPrecision(...undefined));
 console.log((1.23).toExponential(undefined, ...undefined));
 console.log((1.23).toPrecision(undefined, ...undefined));
 console.log((1.23).toPrecision(undefined, 1n + 1));
+console.log((1.23).toPrecision(undefined, 1n >>> 1n));
+console.log((1.23).toFixed(...[2]));
+console.log((1.23).toPrecision(...[2]));
+console.log((1.23).toFixed(...[], 2));
+console.log((1.23).toPrecision(...[], 2));

crates/swc_ecma_minifier/tests/terser/compress/evaluate/number_method_call/output.js

@@ -11,4 +11,9 @@ console.log(1.23.toExponential(...void 0));
 console.log(1.23.toPrecision(...void 0));
 console.log(1.23.toExponential(void 0, ...void 0));
 console.log(1.23.toPrecision(void 0, ...void 0));
-console.log(1.23.toPrecision(void 0, 1n + 1));
+console.log(1.23.toPrecision(void 0, 1n + 1));
+console.log((1.23).toPrecision(void 0, 1n >>> 1n));
+console.log("1.23");
+console.log("1.2");
+console.log("1.23");
+console.log("1.2");

crates/swc_ecma_minifier/tests/terser/compress/evaluate/number_method_call/output.mangleOnly.js

@@ -3605,8 +3605,13 @@ fn may_have_side_effects(expr: &Expr, ctx: ExprCtx) -> bool {
         }) => {
             left.may_have_side_effects(ctx)
                 || right.may_have_side_effects(ctx)
+                // Shift operators may have side effects if one of the operands is BigInt.
+                || matches!(
+                    op,
+                    op!(">>>") if left.is_big_int() || right.is_big_int()
+                )
                 // Arithmetic and Bitwise operators may have side effects if one of the operands is BigInt and the other is not.
-                || (matches!(
+                || matches!(
                     op,
                     op!(bin, "+")
                         | op!(bin, "-")
@@ -3616,10 +3621,9 @@ fn may_have_side_effects(expr: &Expr, ctx: ExprCtx) -> bool {
                         | op!("**")
                         | op!("<<")
                         | op!(">>")
-                        | op!(">>>")
                         | op!("&")
-                        | op!("|"),
-                ) && left.is_big_int() != right.is_big_int())
+                        | op!("|") if left.is_big_int() != right.is_big_int()
+                )
         }
 
         Expr::Member(MemberExpr { obj, prop, .. })