fix(es/minifier): Preserve spread

Author: cuyl

crates/swc_ecma_minifier/src/compress/pure/evaluate.rs

@@ -526,7 +526,7 @@ impl Pure<'_> {
 
         if args
             .iter()
-            .any(|arg| arg.expr.may_have_side_effects(self.expr_ctx))
+            .any(|arg| arg.spread.is_some() || arg.expr.may_have_side_effects(self.expr_ctx))
         {
             return;
         }
@@ -586,9 +586,7 @@ impl Pure<'_> {
         }
 
         if &*method.sym == "toPrecision" {
-            if args.is_empty()
-                || (args[0].spread.is_none() && args[0].expr.is_undefined(self.expr_ctx))
-            {
+            if args.is_empty() || (args[0].expr.is_undefined(self.expr_ctx)) {
                 // https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-number.prototype.toprecision
                 // 2. If precision is undefined, return ! ToString(x).
                 let value = num.value.to_js_string().into();
@@ -609,13 +607,10 @@ impl Pure<'_> {
                 return;
             }
 
-            if let Some(precision) = args.first().and_then(|arg| {
-                if arg.spread.is_none() {
-                    eval_as_number(self.expr_ctx, &arg.expr)
-                } else {
-                    None
-                }
-            }) {
+            if let Some(precision) = args
+                .first()
+                .and_then(|arg| eval_as_number(self.expr_ctx, &arg.expr))
+            {
                 let p = precision.trunc() as usize;
                 // 5. If p < 1 or p > 100, throw a RangeError exception.
                 if !(1..=21).contains(&p) {
@@ -640,9 +635,7 @@ impl Pure<'_> {
         }
 
         if &*method.sym == "toExponential" {
-            if args.is_empty()
-                || (args[0].spread.is_none() && args[0].expr.is_undefined(self.expr_ctx))
-            {
+            if args.is_empty() || (args[0].expr.is_undefined(self.expr_ctx)) {
                 let value = f64_to_exponential(num.value).into();
 
                 self.changed = true;
@@ -659,13 +652,10 @@ impl Pure<'_> {
                 })
                 .into();
                 return;
-            } else if let Some(precision) = args.first().and_then(|arg| {
-                if arg.spread.is_none() {
-                    eval_as_number(self.expr_ctx, &arg.expr)
-                } else {
-                    None
-                }
-            }) {
+            } else if let Some(precision) = args
+                .first()
+                .and_then(|arg| eval_as_number(self.expr_ctx, &arg.expr))
+            {
                 let p = precision.trunc() as usize;
                 // 5. If p < 1 or p > 100, throw a RangeError exception.
                 if !(0..=20).contains(&p) {

crates/swc_ecma_minifier/tests/terser/compress/evaluate/number_method_call/input.js

@@ -4,3 +4,5 @@ console.log((1.23).toExponential(undefined));
 console.log((1.23).toPrecision(undefined));
 console.log((1.23).toExponential(...undefined));
 console.log((1.23).toPrecision(...undefined));
+console.log((1.23).toExponential(undefined, ...undefined));
+console.log((1.23).toPrecision(undefined, ...undefined));

crates/swc_ecma_minifier/tests/terser/compress/evaluate/number_method_call/output.js

@@ -3,4 +3,6 @@ console.log("1.23");
 console.log("1.23e+0");
 console.log("1.23");
 console.log((1.23).toExponential(...void 0));
-console.log((1.23).toPrecision(...void 0));
+console.log((1.23).toPrecision(...void 0));
+console.log((1.23).toExponential(void 0,...void 0));
+console.log((1.23).toPrecision(void 0,...void 0));

crates/swc_ecma_minifier/tests/terser/compress/evaluate/number_method_call/output.mangleOnly.js

@@ -3,4 +3,6 @@ console.log((1.23).toPrecision());
 console.log((1.23).toExponential(undefined));
 console.log((1.23).toPrecision(undefined));
 console.log((1.23).toExponential(...undefined));
-console.log((1.23).toPrecision(...undefined));
+console.log((1.23).toPrecision(...undefined));
+console.log((1.23).toExponential(undefined, ...undefined));
+console.log((1.23).toPrecision(undefined, ...undefined));

crates/swc_ecma_minifier/tests/terser/compress/evaluate/number_method_call/output.terser.js

@@ -3,4 +3,6 @@ console.log("1.23");
 console.log("1.23e+0");
 console.log("1.23");
 console.log((1.23).toExponential(...void 0));
-console.log((1.23).toPrecision(...void 0));
+console.log((1.23).toPrecision(...void 0));
+console.log((1.23).toExponential(void 0, ...void 0));
+console.log((1.23).toPrecision(void 0, ...void 0));