This repository was archived by the owner on Jan 12, 2021. It is now read-only.
Commit 387c543
percpu-add-preemption-checks-to-__this_cpu-ops-fix-checkpatch-fixes
WARNING: storage class should be at the beginning of the declaration
#25: FILE: lib/smp_processor_id.c:10:
+notrace static unsigned int check_preemption_disabled(const char *what1,
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
#36: FILE: lib/smp_processor_id.c:42:
+ printk(KERN_ERR "BUG: using %s%s() in preemptible [%08x] code: %s/%d\n",
ERROR: space required after that ',' (ctx:VxV)
#46: FILE: lib/smp_processor_id.c:56:
+ return check_preemption_disabled("smp_processor_id","");
^
total: 1 errors, 2 warnings, 36 lines checked
./patches/percpu-add-preemption-checks-to-__this_cpu-ops-fix.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Christoph Lameter <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>1 parent abde2af commit 387c543
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
0 commit comments