Skip to content

Conversation

@dnephin
Copy link
Contributor

@dnephin dnephin commented Oct 10, 2014

Hello,

This PR adds a Dockerfile to support building a distribution without having to manually install all of the dependencies on the host.

fehguy added a commit that referenced this pull request Jan 29, 2015
fehguy added a commit that referenced this pull request Jan 29, 2015
@fehguy fehguy closed this Jan 29, 2015
@dnephin
Copy link
Contributor Author

dnephin commented Jan 29, 2015

@fehguy Any reason you're closing this without any comment?

Do you need a rebase?

@dnephin
Copy link
Contributor Author

dnephin commented Jan 29, 2015

Copying and pasting a file in is not at all a manual merge.

I can rebase or change this PR if necessary.

@fehguy
Copy link
Contributor

fehguy commented Jan 29, 2015

Sorry! I manually merged it into develop_2.0

@dnephin
Copy link
Contributor Author

dnephin commented Jan 29, 2015

@fehguy copying my work and committing it as yourself is not a "manual merge".

You also missed the .dockerignore which is important. If you'd like me to remove the README documentation and re-submit to the develop_2.0 branch, I can do that.

@fehguy
Copy link
Contributor

fehguy commented Jan 29, 2015

hmm intention wasn't to copy, this made it easier to merge to the correct branch. I can undo and accept your PR if you like.

@fehguy fehguy reopened this Jan 29, 2015
@dnephin
Copy link
Contributor Author

dnephin commented Jan 29, 2015

I can submit the PR to develop_2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants