Skip to content

fix: moveElemsAttrsToGroups should not move transform if group has filter attribute #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2024
Merged

fix: moveElemsAttrsToGroups should not move transform if group has filter attribute #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6665565
Add filter to list of attributes preserving transform.
johnkenny54 Jan 7, 2024
adf6e27
Simplified test case.
johnkenny54 Jan 15, 2024
ea552d5
Simplified test case.
johnkenny54 Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/moveElemsAttrsToGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,9 @@ export const fn = (root) => {
}
}

// preserve transform on children when group has clip-path or mask
// preserve transform on children when group has filter or clip-path or mask
if (
node.attributes['filter'] != null ||
node.attributes['clip-path'] != null ||
node.attributes.mask != null
) {
Expand Down
29 changes: 29 additions & 0 deletions test/plugins/moveElemsAttrsToGroup.08.svg.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
Don't move transform if there is a filter attribute on group.

===

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
<defs>
<filter id="a" x="17" y="13" width="12" height="10" filterUnits="userSpaceOnUse">
<feGaussianBlur stdDeviation=".01"/>
</filter>
</defs>
<g filter="url(#a)">
<rect x="19" y="12" width="14" height="6" rx="3" transform="rotate(31 19 12.79)"/>
<rect x="19" y="12" width="14" height="6" rx="3" transform="rotate(31 19 12.79)"/>
</g>
</svg>

@@@

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
<defs>
<filter id="a" x="17" y="13" width="12" height="10" filterUnits="userSpaceOnUse">
<feGaussianBlur stdDeviation=".01"/>
</filter>
</defs>
<g filter="url(#a)">
<rect x="19" y="12" width="14" height="6" rx="3" transform="rotate(31 19 12.79)"/>
<rect x="19" y="12" width="14" height="6" rx="3" transform="rotate(31 19 12.79)"/>
</g>
</svg>