Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Sep 24, 2025

follow-up for #14509

pnpm replaces catalog specifiers on publish but we don't want to rely on that behaviour. This should fix the breakage in svelte-ecosytem-ci


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2025

⚠️ No Changeset found

Latest commit: f6a6717

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@dominikg
Copy link
Member

the main reason for me to keep dependencies out of catalog is that it avoids accidentally changing a published package by updating the catalog.
If you edit packages/kit/package.json you are much more likely to remember to add a changeset than if you edit pnpm-workspace.yaml . You'll have to use pnpm why for every updated catalog item and add a changeset.
This includes renovate PRs too because that knows how to update catalogs.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea just for the sake of changesets

@Rich-Harris Rich-Harris merged commit 85596d0 into main Sep 24, 2025
22 checks passed
@Rich-Harris Rich-Harris deleted the chore-revert-catalogs-for-deps branch September 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants