Skip to content

Conversation

@suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke commented Oct 3, 2024

Add the option -ignore-warning to the tfcmt plan command.
You can also configure this option in your configuration file.

terraform:
  plan:
    ignore_warning: true

By default, tfcmt emphasizes the warning of terraform plan, and the option -skip-no-changes is ignored if terraform plan outputs warning.

image

This is because we think warning should not be ignored.

But actually we're aware that some users ignore warning normally and they feel warning is noisy.
In this case, it's desirable that tfcmt plan -skip-no-changes doesn't post a comment even if warning is outputted.

So this pull request introduces a new option -ignore-warning.

If terraform plan outputs warning, this option makes the template variable .Warning empty, removing the warning from the default template.

If terraform plan -skip-no-changes has no change and outputs warning, this option disables to post a comment.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Oct 3, 2024
@suzuki-shunsuke suzuki-shunsuke added this to the v4.13.1 milestone Oct 3, 2024
@suzuki-shunsuke suzuki-shunsuke merged commit 10d6eda into main Oct 4, 2024
8 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the feat-add-ignore-warning branch October 4, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants