Reintroduce Command Group Tags (Group 0000) #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlibanori
force-pushed
the
tag-commandSet
branch
from
7fd5be4 to
f0ab704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the command group tags (group 0000) that were removed in PR #316.
While it's true that the current project does not directly handle DIMSE messages or use these tags, it's important to highlight that this library may serve as a foundational component in other projects — including those implementing the DICOM Upper Layer Protocol, which facilitates network communication in the DICOM standard.
The command group tags are defined in the DICOM standard for a reason. Although they do not appear in standard DICOM files, they are essential for parsing and constructing DIMSE messages, which operate over the DICOM Upper Layer Protocol (DUL). Removing them entirely reduces the flexibility and applicability of this package in broader DICOM-related use cases.
Changes included:
Re-added the group 0000 (command group) tags to the tag definitions.
Added tests to validate the presence and structure of command group tags.