Skip to content

Commit 1a006d1

Browse files
committed
Edit test to ensure we can now write Pixel Data with OB VR
1 parent 808f3ba commit 1a006d1

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

write_test.go

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@ import (
66
"os"
77
"testing"
88

9-
"github.com/suyashkumar/dicom/pkg/vrraw"
10-
119
"github.com/suyashkumar/dicom/pkg/frame"
10+
"github.com/suyashkumar/dicom/pkg/vrraw"
1211

1312
"github.com/google/go-cmp/cmp/cmpopts"
1413

@@ -400,17 +399,23 @@ func TestWrite(t *testing.T) {
400399
dataset: Dataset{Elements: []*Element{
401400
mustNewElement(tag.MediaStorageSOPClassUID, []string{"1.2.840.10008.5.1.4.1.1.1.2"}),
402401
mustNewElement(tag.MediaStorageSOPInstanceUID, []string{"1.2.3.4.5.6.7"}),
403-
mustNewElement(tag.TransferSyntaxUID, []string{uid.ImplicitVRLittleEndian}),
402+
mustNewElement(tag.TransferSyntaxUID, []string{uid.ExplicitVRLittleEndian}),
404403
mustNewElement(tag.BitsAllocated, []int{8}),
405-
setUndefinedLength(mustNewElement(tag.PixelData, PixelDataInfo{
406-
IsEncapsulated: true,
407-
Frames: []*frame.Frame{
408-
{
409-
Encapsulated: true,
410-
EncapsulatedData: frame.EncapsulatedFrame{Data: []byte{1, 2, 3, 4}},
404+
setUndefinedLength(&Element{
405+
Tag: tag.PixelData,
406+
ValueRepresentation: tag.VRPixelData,
407+
// Encapsulated should always have OB VR, but mustNewElement would make it OW.
408+
RawValueRepresentation: "OB",
409+
Value: mustNewValue(PixelDataInfo{
410+
IsEncapsulated: true,
411+
Frames: []*frame.Frame{
412+
{
413+
Encapsulated: true,
414+
EncapsulatedData: frame.EncapsulatedFrame{Data: []byte{1, 2, 3, 4}},
415+
},
411416
},
412-
},
413-
})),
417+
}),
418+
}),
414419
mustNewElement(tag.FloatingPointValue, []float64{128.10}),
415420
mustNewElement(tag.DimensionIndexPointer, []int{32, 36950}),
416421
}},

0 commit comments

Comments
 (0)