Skip to content

Commit 2e0c969

Browse files
[DevTools] Enable pointEvents while scrolling (facebook#30560)
[`react-window` disables `pointerEvents` while scrolling meaning you can't click anything while scrolling.](bvaughn/react-window#128). This means that the first click when you stop the scroll with inertial scrolling doesn't get registered. This is suuuper annoying. This might make sense when you click to stop on a more intentional UI but it doesn't makes sense in a list like this because we eagerly click things even on mousedown. This PR just override that to re-enable pointer events. Supposedly this is done for performance but that might be outdated knowledge. I haven't observed any difference so far. If we discover that it's a perf problem, there's another technique we can use where we call `ownerDocument.elementFromPoint(e.pageX, e.pageY)` and then dispatch the event against that element. But let's try the simplest approach first? DiffTrain build for commit facebook@06d0b89.
1 parent 9a7dd61 commit 2e0c969

File tree

14 files changed

+4386
-3710
lines changed

14 files changed

+4386
-3710
lines changed

compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-41ecbada-20240730
1+
19.0.0-native-fb-06d0b89e-20240801

0 commit comments

Comments
 (0)