Panic if SpinLock locked in interrupt context #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It looks like maybe I should fiddle with this a bit more if syscall context is not considered irq context. (Is it? It's the only 'interrupt' where interrupts are not disabled.) maybe add an extra thing to the macro? |
Member
|
Indeed, syscall context isn't interrupt context 😕 |
Orycterope
reviewed
Oct 27, 2019
Contributor
Author
|
Thanks for the feedback, I'll try to get to that today. Fixing syscall context in particular is going to be annoying (but that'll also lay the groundwork for switching back to counter-based SpinLockIRQ, i think.) |
roblabla
approved these changes
Oct 28, 2019
Member
|
LGTM, can get merged after a rebase :) |
Fixes sunriseos#471. This involves creating a newtype wrapper around spin::Mutex to check when locking if the number of interrupts being services is currently zero.
kitlith
force-pushed
the
spinlock_noirq
branch
from
ca42019 to
d30731f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471.
This involves creating a newtype wrapper around spin::Mutex to check when locking if the number of interrupts being serviced is currently zero.