Fix scheduler peer state (dragonflyoss#1267)

* fix: prevent traversal tree from infinite loop

Signed-off-by: Gaius <gaius.qi@gmail.com>

* fix: schedule peer state

Signed-off-by: Gaius <gaius.qi@gmail.com>

Author: gaius-qi

scheduler/resource/peer.go

@@ -353,6 +353,9 @@ func (p *Peer) ReplaceParent(parent *Peer) {
 
 // Depth represents depth of tree
 func (p *Peer) Depth() int {
+	p.mu.RLock()
+	defer p.mu.RUnlock()
+
 	node := p
 	var depth int
 	for node != nil {
@@ -381,22 +384,19 @@ func (p *Peer) Depth() int {
 
 // IsDescendant determines whether it is ancestor of peer
 func (p *Peer) IsDescendant(ancestor *Peer) bool {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-
 	return p.isDescendant(ancestor, p)
 }
 
 // IsAncestor determines whether it is descendant of peer
 func (p *Peer) IsAncestor(descendant *Peer) bool {
-	p.mu.RLock()
-	defer p.mu.RUnlock()
-
 	return p.isDescendant(p, descendant)
 }
 
 // isDescendant determines whether it is ancestor of peer
 func (p *Peer) isDescendant(ancestor, descendant *Peer) bool {
+	p.mu.RLock()
+	defer p.mu.RUnlock()
+
 	node := descendant
 	for node != nil {
 		parent, ok := node.LoadParent()

scheduler/scheduler/evaluator/evaluator_base.go

@@ -177,7 +177,8 @@ func calculateMultiElementAffinityScore(dst, src string) float64 {
 }
 
 func (eb *evaluatorBase) IsBadNode(peer *resource.Peer) bool {
-	if peer.FSM.Is(resource.PeerStateFailed) || peer.FSM.Is(resource.PeerStateLeave) || peer.FSM.Is(resource.PeerStatePending) {
+	if peer.FSM.Is(resource.PeerStateFailed) || peer.FSM.Is(resource.PeerStateLeave) || peer.FSM.Is(resource.PeerStatePending) ||
+		peer.FSM.Is(resource.PeerStateReceivedTiny) || peer.FSM.Is(resource.PeerStateReceivedSmall) || peer.FSM.Is(resource.PeerStateReceivedNormal) {
 		peer.Log.Debugf("peer is bad node because peer status is %s", peer.FSM.Current())
 		return true
 	}

scheduler/scheduler/evaluator/evaluator_base_test.go

@@ -593,6 +593,54 @@ func TestEvaluatorBase_IsBadNode(t *testing.T) {
 				assert.True(isBadNode)
 			},
 		},
+		{
+			name:            "peer state is PeerStatePending",
+			peer:            resource.NewPeer(mockPeerID, mockTask, mockHost),
+			totalPieceCount: 1,
+			mock: func(peer *resource.Peer) {
+				peer.FSM.SetState(resource.PeerStatePending)
+			},
+			expect: func(t *testing.T, isBadNode bool) {
+				assert := assert.New(t)
+				assert.True(isBadNode)
+			},
+		},
+		{
+			name:            "peer state is PeerStateReceivedTiny",
+			peer:            resource.NewPeer(mockPeerID, mockTask, mockHost),
+			totalPieceCount: 1,
+			mock: func(peer *resource.Peer) {
+				peer.FSM.SetState(resource.PeerStateReceivedTiny)
+			},
+			expect: func(t *testing.T, isBadNode bool) {
+				assert := assert.New(t)
+				assert.True(isBadNode)
+			},
+		},
+		{
+			name:            "peer state is PeerStateReceivedSmall",
+			peer:            resource.NewPeer(mockPeerID, mockTask, mockHost),
+			totalPieceCount: 1,
+			mock: func(peer *resource.Peer) {
+				peer.FSM.SetState(resource.PeerStateReceivedSmall)
+			},
+			expect: func(t *testing.T, isBadNode bool) {
+				assert := assert.New(t)
+				assert.True(isBadNode)
+			},
+		},
+		{
+			name:            "peer state is PeerStateReceivedNormal",
+			peer:            resource.NewPeer(mockPeerID, mockTask, mockHost),
+			totalPieceCount: 1,
+			mock: func(peer *resource.Peer) {
+				peer.FSM.SetState(resource.PeerStateReceivedNormal)
+			},
+			expect: func(t *testing.T, isBadNode bool) {
+				assert := assert.New(t)
+				assert.True(isBadNode)
+			},
+		},
 		{
 			name:            "download costs does not meet the normal distribution and last cost is twenty times more than mean",
 			peer:            resource.NewPeer(mockPeerID, mockTask, mockHost),