Remove all but one use of tool_runner.sh

Author: stuartmorgan-g

.cirrus.yml

@@ -6,6 +6,10 @@ only_if: $CIRRUS_TAG == ''
 env:
   CHANNEL: "master" # Default to master when not explicitly set by a task.
   PLUGIN_TOOL: "./script/tool/bin/flutter_plugin_tools.dart"
+  # The base command flags for most tool invocations, handling:
+  # - running the correct set of packages for the current branch
+  # - including any sharding that is configured for a task via $PLUGIN_SHARDING
+  COMMON_FLAGS: --packages-for-branch $PLUGIN_SHARDING
 
 tool_setup_template: &TOOL_SETUP_TEMPLATE
   tool_setup_script:
@@ -68,19 +72,19 @@ task:
         - cd script/tool
         - CIRRUS_BUILD_ID=null pub run test
     - name: publishable
-      version_check_script: ./script/tool_runner.sh version-check
-      publish_check_script: ./script/tool_runner.sh publish-check
+      version_check_script: dart $PLUGIN_TOOL version-check $COMMON_FLAGS
+      publish_check_script: dart $PLUGIN_TOOL publish-check $COMMON_FLAGS
     - name: format
-      format_script: ./script/tool_runner.sh format --fail-on-change
-      pubspec_script: ./script/tool_runner.sh pubspec-check
+      format_script: dart $PLUGIN_TOOL format --fail-on-change $COMMON_FLAGS
+      pubspec_script: dart $PLUGIN_TOOL pubspec-check $COMMON_FLAGS
       license_script: dart $PLUGIN_TOOL license-check
     - name: test
       env:
         matrix:
           CHANNEL: "master"
           CHANNEL: "stable"
       test_script:
-        - ./script/tool_runner.sh test
+        - dart $PLUGIN_TOOL test $COMMON_FLAGS
     - name: analyze
       env:
         matrix:
@@ -90,8 +94,12 @@ task:
         - cd script/tool
         - dart analyze --fatal-infos
       script:
-        # DO NOT change the custom-analysis argument here without changing the Dart repo.
+        # DO NOT change anything about this command without changing the
+        # dart-lang/sdk and flutter/flutter repositories first.
         # See the comment in script/configs/custom_analysis.yaml for details.
+        # This deliberately still uses tool_runner.sh to ensure that changes
+        # that would cause this command to fail show up here, not in the other
+        # repositories.
         - ./script/tool_runner.sh analyze --custom-analysis=script/configs/custom_analysis.yaml
     ### Android tasks ###
     - name: build_all_plugins_apk
@@ -126,9 +134,9 @@ task:
           CHANNEL: "stable"
       build_script:
         - flutter config --enable-linux-desktop
-        - ./script/tool_runner.sh build-examples --linux
+        - dart $PLUGIN_TOOL build-examples --linux $COMMON_FLAGS
       drive_script:
-        - xvfb-run ./script/tool_runner.sh drive-examples --linux
+        - xvfb-run dart $PLUGIN_TOOL drive-examples --linux $COMMON_FLAGS
 
 # Heavy-workload Linux tasks.
 # These use machines with more CPUs and memory, so will reduce parallelization
@@ -164,14 +172,15 @@ task:
         # TODO(stuartmorgan): See https://github.com/flutter/flutter/issues/24935
         - export CIRRUS_CHANGE_MESSAGE=""
         - export CIRRUS_COMMIT_MESSAGE=""
-        - ./script/tool_runner.sh build-examples --apk
+        - dart $PLUGIN_TOOL build-examples --apk $COMMON_FLAGS
       lint_script:
         # Unsetting CIRRUS_CHANGE_MESSAGE and CIRRUS_COMMIT_MESSAGE as they
         # might include non-ASCII characters which makes Gradle crash.
         # TODO(stuartmorgan): See https://github.com/flutter/flutter/issues/24935
         - export CIRRUS_CHANGE_MESSAGE=""
         - export CIRRUS_COMMIT_MESSAGE=""
-        - ./script/tool_runner.sh lint-android # must come after build-examples
+        # Must come after build-examples.
+        - dart $PLUGIN_TOOL lint-android $COMMON_FLAGS
       native_unit_test_script:
         # Unsetting CIRRUS_CHANGE_MESSAGE and CIRRUS_COMMIT_MESSAGE as they
         # might include non-ASCII characters which makes Gradle crash.
@@ -180,7 +189,8 @@ task:
         - export CIRRUS_COMMIT_MESSAGE=""
         # Native integration tests are handled by firebase-test-lab below, so
         # only run unit tests.
-        - ./script/tool_runner.sh native-test --android --no-integration  # must come after apk build
+        # Must come after build-examples.
+        - dart $PLUGIN_TOOL native-test --android --no-integration $COMMON_FLAGS
       firebase_test_lab_script:
         # Unsetting CIRRUS_CHANGE_MESSAGE and CIRRUS_COMMIT_MESSAGE as they
         # might include non-ASCII characters which makes Gradle crash.
@@ -189,7 +199,7 @@ task:
         - export CIRRUS_COMMIT_MESSAGE=""
         - if [[ -n "$GCLOUD_FIREBASE_TESTLAB_KEY" ]]; then
         -   echo $GCLOUD_FIREBASE_TESTLAB_KEY > ${HOME}/gcloud-service-key.json
-        -   ./script/tool_runner.sh firebase-test-lab --device model=flame,version=29 --device model=starqlteue,version=26 --exclude=script/configs/exclude_integration_android.yaml
+        -   dart $PLUGIN_TOOL firebase-test-lab --device model=flame,version=29 --device model=starqlteue,version=26 --exclude=script/configs/exclude_integration_android.yaml $COMMON_FLAGS
         - else
         -   echo "This user does not have permission to run Firebase Test Lab tests."
         - fi
@@ -212,9 +222,9 @@ task:
         - dart lib/web_driver_installer.dart chromedriver --install-only
         - ./chromedriver/chromedriver --port=4444 &
       build_script:
-        - ./script/tool_runner.sh build-examples --web
+        - dart $PLUGIN_TOOL build-examples --web $COMMON_FLAGS
       drive_script:
-        - ./script/tool_runner.sh drive-examples --web --exclude=script/configs/exclude_integration_web.yaml
+        - dart $PLUGIN_TOOL drive-examples --web --exclude=script/configs/exclude_integration_web.yaml $COMMON_FLAGS
 
 # macOS tasks.
 task:
@@ -224,7 +234,7 @@ task:
     ### iOS+macOS tasks ***
     - name: lint_darwin_plugins
       script:
-        - ./script/tool_runner.sh podspecs
+        - dart $PLUGIN_TOOL podspecs $COMMON_FLAGS
     ### iOS tasks ###
     - name: build_all_plugins_ipa
       env:
@@ -249,16 +259,16 @@ task:
         - xcrun simctl list
         - xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-14-5 | xargs xcrun simctl boot
       build_script:
-        - ./script/tool_runner.sh build-examples --ios
+        - dart $PLUGIN_TOOL build-examples --ios $COMMON_FLAGS
       xcode_analyze_script:
-        - ./script/tool_runner.sh xcode-analyze --ios
+        - dart $PLUGIN_TOOL xcode-analyze --ios $COMMON_FLAGS
       native_test_script:
-        - ./script/tool_runner.sh native-test --ios --ios-destination "platform=iOS Simulator,name=iPhone 11,OS=latest"
+        - dart $PLUGIN_TOOL native-test --ios --ios-destination "platform=iOS Simulator,name=iPhone 11,OS=latest" $COMMON_FLAGS
       drive_script:
         # `drive-examples` contains integration tests, which changes the UI of the application.
         # This UI change sometimes affects `xctest`.
         # So we run `drive-examples` after `native-test`; changing the order will result ci failure.
-        - ./script/tool_runner.sh drive-examples --ios --exclude=script/configs/exclude_integration_ios.yaml
+        - dart $PLUGIN_TOOL drive-examples --ios --exclude=script/configs/exclude_integration_ios.yaml $COMMON_FLAGS
     ### macOS desktop tasks ###
     - name: build_all_plugins_macos
       env:
@@ -277,10 +287,10 @@ task:
         PATH: $PATH:/usr/local/bin
       build_script:
         - flutter config --enable-macos-desktop
-        - ./script/tool_runner.sh build-examples --macos
+        - dart $PLUGIN_TOOL build-examples --macos $COMMON_FLAGS
       xcode_analyze_script:
-        - ./script/tool_runner.sh xcode-analyze --macos
+        - dart $PLUGIN_TOOL xcode-analyze --macos $COMMON_FLAGS
       native_test_script:
-        - ./script/tool_runner.sh native-test --macos --exclude=script/configs/exclude_native_macos.yaml
+        - dart $PLUGIN_TOOL native-test --macos --exclude=script/configs/exclude_native_macos.yaml $COMMON_FLAGS
       drive_script:
-        - ./script/tool_runner.sh drive-examples --macos
+        - dart $PLUGIN_TOOL drive-examples --macos $COMMON_FLAGS

script/configs/custom_analysis.yaml

@@ -8,9 +8,11 @@
 # from a top-level package into more specific packages in order to incrementally
 # migrate a federated plugin.
 #
-# DO NOT move or delete this file without updating
+# DO NOT move or delete this file without updating both
 # https://github.com/dart-lang/sdk/blob/master/tools/bots/flutter/analyze_flutter_plugins.sh
-# which references this file from source, but out-of-repo.
+# and
+# https://github.com/flutter/flutter/blob/master/dev/bots/test.dart
+# which reference this file from source, but out-of-repo.
 # Contact stuartmorgan or devoncarew for assistance if necessary.
 
 # TODO(ecosystem): Remove everything from this list. See: