Skip to content

Conversation

@Firoj-Patel
Copy link
Contributor

Type of change

  • Enhancement / new feature

Description

As per the discussion thread here, we have now setup the CI for s390x at https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/ and would like to add a build status badge in the README.md file.
The badge provides a visual indicator of the latest build status (e.g., passing, failing, or in progress) from the S390x Jenkins pipeline.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

This commit adds the appropriate tag to support the newly migrated Continuous Integration (CI) pipeline for the s390x architecture on Jenkins.
Signed-off-by: Firoj-IBM <[email protected]>
@ppatierno ppatierno requested a review from a team October 20, 2025 09:36
README.md Outdated
[![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0)
[![Twitter Follow](https://img.shields.io/twitter/follow/strimziio?style=social)](https://twitter.com/strimziio)
[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/strimzi-kafka-operator)](https://artifacthub.io/packages/search?repo=strimzi-kafka-operator)
[![s390x build Status](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/badge/icon)](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As triaged on the last community call we would like to have a dedicated section in the README with budges coming from the community and not together with the official ones.
You should create a new section at the bottom of this README with this new badge.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.79%. Comparing base (386d218) to head (6bb31c3).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12044      +/-   ##
============================================
- Coverage     74.91%   74.79%   -0.13%     
- Complexity     6454     6625     +171     
============================================
  Files           343      377      +34     
  Lines         24336    25359    +1023     
  Branches       3207     3396     +189     
============================================
+ Hits          18232    18966     +734     
- Misses         4830     5005     +175     
- Partials       1274     1388     +114     

see 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Firoj-IBM <[email protected]>
README.md Outdated
Comment on lines 111 to 113
### Architecture support
#### Linux on IBM Z (s390x) :
[![Jenkins](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/badge/icon)](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Just a it about the formatting and fixing the header levels to not have it folded under the SBOM chapter.

Suggested change
### Architecture support
#### Linux on IBM Z (s390x) :
[![Jenkins](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/badge/icon)](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/)
## Architecture support
### Linux on IBM Z (s390x) :
[![Jenkins](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/badge/icon)](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Would it be appropriate to insert this section right after the License chapter in the README? I'd like to confirm before updating the file. Thanks.

@scholzj scholzj requested a review from a team October 22, 2025 20:45
@scholzj scholzj added this to the 0.49.0 milestone Oct 22, 2025
@ppatierno
Copy link
Member

I think the current position is fine. But I agree with the suggestions by Jakub.

Signed-off-by: Firoj-IBM <[email protected]>
@Firoj-Patel
Copy link
Contributor Author

Updated file per Jakub’s suggestions.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be fine with me if it moves right after the license section. But I can speak only for my self. Not sure about the others. In any case the PR looks good also as it is right now.

@katheris @im-konge @Frawless I think you were part of the dicussion on the triage call ... can you have a look as well?

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe after the license section it would be better. LGTM thanks.

Signed-off-by: Firoj-IBM <[email protected]>
@Firoj-Patel
Copy link
Contributor Author

@scholzj Moved the block below the Licence section to improve structure.

Copy link
Member

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should go in this PR or a separate one from a Strimzi maintainer, but should we have a heading under Architecture support for each architecture we build for? Otherwise it could be misconstrued that we only have an s390x build and no other builds.

Alternatively maybe the section could be titled Community-provided architecture support? @scholzj @ppatierno @im-konge @Frawless what do you think?

@scholzj
Copy link
Member

scholzj commented Oct 27, 2025

@katheris I think it is a bit more complicated then that. Maybe we can revisit it on Thursday on the community call. But basically:

  • Whole Strimzi is community-supported. The vendor products based on Strimzi might have other forms of support. But Strimzi itself is always community-supported.
  • The build itself has nothing to do with supported architectures ... whatever supported means here. We produce the images for s390x and ppc64le (in the same way as we do for Aarch64 and Amd64). We just do not test for those two platforms and just do the build. We might not be good at communicating it. It was always part of the initial support announcement, but that was years ago. So no idea how many people still know about it. If you start using Strimzi today, it is not likely that you read the CHANGELOG for Strimzi 0.29. What the build does is only running tests for Strimzi. I have no idea which ones (STs I assume?) and I have no idea if it uses our binaries or the self-produced binaries. This is part of why I feel the need to make it clear that it is not official -> we do not know what it does, we do not rely on it, wait for releases, we do not know if it is testing the release binaries or not. But in any case, the Strimzi binaries for s390x are still our binaries. This is probably not easy to put into something easy to understand. But at the end, we probably from our side want to make sure that it is clear to understand that:
    • The s390x binaries are produced by Strimzi in the same way as the binaries for other platforms
    • Strimzi project does no testing on these platforms and offers no guarantees
    • There are these outside folks who run the tests on s390x and will alert us about problems. They deserve credit for it! But it is not directly part of the Strimzi workflows, but rather works async / out-of-band.

@katheris
Copy link
Member

Discussed on community call on 30/10/25: The heading "Architecture Support" here is confusing, we should change this to "Community Testing" as that is a clearer description of what this badge represents.

@Firoj-Patel if you could go ahead and change the wording then I can approve it

Signed-off-by: Firoj-IBM <[email protected]>
@Firoj-Patel
Copy link
Contributor Author

Discussed on community call on 30/10/25: The heading "Architecture Support" here is confusing, we should change this to "Community Testing" as that is a clearer description of what this badge represents.

@Firoj-Patel if you could go ahead and change the wording then I can approve it

@katheris updated as per your suggestion.

Copy link
Member

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Firoj-Patel

README.md Outdated

## Community Testing

### Linux on IBM Z (s390x) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit for the formatting

Suggested change
### Linux on IBM Z (s390x) :
### Linux on IBM Z (s390x)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done,
Thanks for suggestion.

Signed-off-by: Firoj-IBM <[email protected]>
@scholzj scholzj merged commit 28f3932 into strimzi:main Nov 3, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants