[Fix] The most recent changes to golang/protobuf breaks the spew Circular data structure detection

Graham Jenson · boyan-soubachov · commit 8fb4b2442e11 · 2020-11-03T21:38:56.000+11:00
The latest update to golang/protobuf (I am on v1.4.2) break the spew circular data structure detection. This means that when calling `assert.Equal(t, proto1, proto2)` will not only fail, but also enter an infinite recursion.

Given spew is not being actively maintained, and tesitfy should set some upper bound, we need to set a `MaxDepth` to some very high number, so at least the test will not run for a very long time and finish and fail quickly.
diff --git a/assert/assertions.go b/assert/assertions.go
@@ -1622,6 +1622,7 @@ var spewConfig = spew.ConfigState{
 	DisableCapacities:       true,
 	SortKeys:                true,
 	DisableMethods:          true,
+	MaxDepth:                100,
 }
 
 type tHelper interface {

Original file line number	Diff line number	Diff line change
`@@ -1622,6 +1622,7 @@ var spewConfig = spew.ConfigState{`
`1622`	`1622`	`DisableCapacities: true,`
`1623`	`1623`	`SortKeys: true,`
`1624`	`1624`	`DisableMethods: true,`
	`1625`	`+ MaxDepth: 100,`
`1625`	`1626`	`}`
`1626`	`1627`
`1627`	`1628`	`type tHelper interface {`