monographs: add slug field which regenerates on update #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01zulfi
force-pushed
the
monograph/editable-url
branch
from
4fe5107 to
7e0e5fa
Compare
01zulfi
changed the title
01zulfi
commented
Nov 25, 2025
Comment on lines
+238
to
+246
| if (!string.IsNullOrEmpty(monograph?.Slug)) | ||
| { | ||
| return NotFound(new | ||
| { | ||
| error = "invalid_id", | ||
| error_description = $"No such monograph found." | ||
| }); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm still contemplating if we need to add this check. On one hand, I think it makes sense to restrict fetching monograph by id if the slug exists. On another hand, if a user's client app is a bit behind (i.e. doesn't have the slug property yet), they'll be shown the monograph link with the id which will be a 404 causing confusion
01zulfi
force-pushed
the
monograph/editable-url
branch
from
7e0e5fa to
5717b67
Compare
01zulfi
commented
Nov 26, 2025
| return Ok(); | ||
| } | ||
|
|
||
| [HttpGet("{id}/publish-url")] |
Contributor
Author
There was a problem hiding this comment.
maybe we can combine analytics and publish-url endpoints into one?
Comment on lines
-278
to
+292
| var userMonographs = await Repositories.Monographs.Collection.Find(filter).Project((m) => new MonographMetadata | ||
| var userMonographs = await Repositories.Monographs.Collection.Find(filter).ToListAsync(); | ||
| var userMonographMetadatas = userMonographs.Select((m) => new MonographMetadata | ||
| { | ||
| DatePublished = m.DatePublished, | ||
| Deleted = m.Deleted, | ||
| Password = m.Password, | ||
| SelfDestruct = m.SelfDestruct, | ||
| Title = m.Title, | ||
| PublishUrl = m.ConstructPublishUrl(), | ||
| ItemId = m.ItemId ?? m.Id.ToString(), | ||
| ViewCount = m.ViewCount | ||
| }).ToListAsync(); | ||
| }).ToList(); | ||
|
|
||
| if (userMonographs.Count > 0 && !await Clients.Caller.SendMonographs(userMonographs).WaitAsync(TimeSpan.FromMinutes(10))) | ||
| if (userMonographMetadatas.Count > 0 && !await Clients.Caller.SendMonographs(userMonographMetadatas).WaitAsync(TimeSpan.FromMinutes(10))) |
Contributor
Author
There was a problem hiding this comment.
I was unable to use m.ConstructPublishUrl method inside MongoDB's Project. It would throw expression not supported exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.