Skip to content

Conversation

@strarsis
Copy link
Owner

@strarsis strarsis commented Feb 13, 2021

@DanielBiegler: UI interaction confirmation feature was added to Pannellum which also adds new interaction message strings.
This PR adds the German non-formal and formal translations for these new strings.

@DanielBiegler
Copy link
Collaborator

Nice work on the PR! I'll get this merged now but updating the npm package has to wait a day or two. :)

@DanielBiegler
Copy link
Collaborator

Oh btw @strarsis would you like to take over this repo and the npm package? Then I can stop being a bottleneck for future updates.

@DanielBiegler DanielBiegler merged commit fda0267 into strarsis:master Feb 18, 2021
@strarsis
Copy link
Owner Author

strarsis commented Feb 18, 2021

@DanielBiegler: Yes, you can make me repo maintainer, if you'd like.
Edit: And I need the npm credentials so I can push the packages under the same author/name?

@DanielBiegler
Copy link
Collaborator

@strarsis you need to delete your fork of this repo, else I get the following error:

strarsis/pannellum-translation already exists

After that you'll get a confirmation mail. More info from Github: https://docs.github.com/en/github/administering-a-repository/transferring-a-repository

Also I need your NPM username, after that I'll sort that out, here the npm docs: https://docs.npmjs.com/transferring-a-package-from-a-user-account-to-another-user-account

@strarsis
Copy link
Owner Author

strarsis commented Mar 25, 2021

@DanielBiegler: This passed out of mind a bit, sorry.

  1. The GitHub fork strarsis/pannellum-translation was deleted.
  2. Please re-start the transfer so I can get the confirmation email and confirm the transfer.
  3. My npm username is strarsis (same as in GitHub).

@DanielBiegler
Copy link
Collaborator

@strarsis OK, I started the transfer on Github, check your mail. I added you as a maintainer on NPM as well. Please confirm when you accept. After you confirm I can remove myself! Have a nice day! :)

@strarsis
Copy link
Owner Author

@DanielBiegler: OK, transfer is completed. I am maintainer now of the pannellum-translation package and this repository was transferred to my GitHub account.

@DanielBiegler
Copy link
Collaborator

Nice. I removed myself from NPM now. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants