-
Notifications
You must be signed in to change notification settings - Fork 10
Support name in manifest errors #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f5b610d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle ReportChanges will increase total bundle size by 215 bytes (0.57%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @storybook/mcp-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #55 +/- ##
==========================================
+ Coverage 82.20% 82.56% +0.35%
==========================================
Files 15 15
Lines 843 843
Branches 159 162 +3
==========================================
+ Hits 693 696 +3
+ Misses 142 139 -3
Partials 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for handling error states in component manifests by updating the schema to include an error name field and adding comprehensive test coverage for various error scenarios.
Key Changes:
- Added
namefield to theerrorobject schema in component and example manifests - Created a new test fixture (
with-errors.fixture.json) demonstrating five different error scenarios - Added test cases verifying that components and examples with errors are handled gracefully (skipped when rendering)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/mcp/src/types.ts |
Added name field to error object schema for better error identification |
packages/mcp/fixtures/with-errors.fixture.json |
New test fixture with realistic error scenarios including mixed success/error states |
packages/mcp/src/utils/format-manifest.test.ts |
Added comprehensive tests verifying error handling behavior in formatting functions |
packages/mcp/src/utils/error-to-mcp-content.test.ts |
Reformatted multi-line constructor call to single line |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
storybookjs/storybook#32882 introduces
nameto errors. This updates the validation to include that.