Skip to content

Commit 5601e96

Browse files
[dockers] Tag all docker images with a version number
Previously all docker images built into SONiC binary were tagged with SONiC version string. With the introduction of container upgrades and SONiC extension framework all docker images should have their own version numbers that do not relate with SONiC version. All dockers are tagged with version 1.0.0 in this PR. Whenever changes are introduced to a docker image that require a version change, the docker image maintainer should update the version number. Signed-off-by: Stepan Blyschak <[email protected]>
1 parent 1be9c4a commit 5601e96

43 files changed

Lines changed: 81 additions & 6 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

files/build_templates/sonic_debian_extension.j2

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -501,13 +501,15 @@ sudo mkdir $FILESYSTEM_ROOT/target
501501
sudo mount --bind target $FILESYSTEM_ROOT/target
502502
sudo chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS info
503503
{% for image in installer_images.strip().split(' ') -%}
504-
{% set imagefilename = image.split('/')|last -%}
504+
{% set imagefilepath = image.split(':')|first -%}
505+
{% set imageversion = image.split(':')|last -%}
506+
{% set imagefilename = imagefilepath.split('/')|last -%}
505507
{% set imagename = imagefilename.split('.')|first -%}
506-
sudo LANG=C chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS load -i {{image}}
507-
sudo LANG=C chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS tag {{imagename}}:latest {{imagename}}:"${SONIC_IMAGE_VERSION}"
508+
sudo LANG=C chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS load -i {{imagefilepath}}
509+
sudo LANG=C chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS tag {{imagename}}:latest {{imagename}}:{{imageversion}}
508510
{% if imagename.endswith('-dbg') %}
509511
{% set imagebasename = imagename.replace('-dbg', '') -%}
510-
sudo LANG=C chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS tag {{imagename}}:latest {{imagebasename}}:"${SONIC_IMAGE_VERSION}"
512+
sudo LANG=C chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS tag {{imagename}}:latest {{imagebasename}}:{{imageversion}}
511513
sudo LANG=C chroot $FILESYSTEM_ROOT docker $SONIC_NATIVE_DOCKERD_FOR_DOCKERFS tag {{imagename}}:latest {{imagebasename}}:latest
512514
{% endif %}
513515
{% endfor %}

platform/barefoot/docker-syncd-bfn-rpc.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_BFN_RPC)
1818
endif
1919

2020
$(DOCKER_SYNCD_BFN_RPC)_CONTAINER_NAME = syncd
21+
$(DOCKER_SYNCD_BFN_RPC)_VERSION = 1.0.0
2122
$(DOCKER_SYNCD_BFN_RPC)_RUN_OPT += --net=host --privileged -t
2223
$(DOCKER_SYNCD_BFN_RPC)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf
2324
$(DOCKER_SYNCD_BFN_RPC)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro

platform/barefoot/docker-syncd-bfn.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ $(DOCKER_SYNCD_BASE)_DBG_DEPENDS += $(SYNCD_DBG) \
1010
$(LIBSAIMETADATA_DBG) \
1111
$(LIBSAIREDIS_DBG)
1212

13+
$(DOCKER_SYNCD_BASE)_VERSION = 1.0.0
14+
1315
SONIC_STRETCH_DOCKERS += $(DOCKER_SYNCD_BASE)
1416
SONIC_STRETCH_DBG_DOCKERS += $(DOCKER_SYNCD_BASE_DBG)
1517

platform/broadcom/docker-syncd-brcm-rpc.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_BRCM_RPC)
1818
endif
1919

2020
$(DOCKER_SYNCD_BRCM_RPC)_CONTAINER_NAME = syncd
21+
$(DOCKER_SYNCD_BRCM_RPC)_VERSION = 1.0.0
2122
$(DOCKER_SYNCD_BRCM_RPC)_RUN_OPT += --privileged -t
2223
$(DOCKER_SYNCD_BRCM_RPC)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf
2324
$(DOCKER_SYNCD_BRCM_RPC)_RUN_OPT += -v /host/warmboot:/var/warmboot

platform/broadcom/docker-syncd-brcm.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ $(DOCKER_SYNCD_BASE)_DBG_DEPENDS += $(SYNCD_DBG) \
1414
SONIC_STRETCH_DOCKERS += $(DOCKER_SYNCD_BASE)
1515
SONIC_STRETCH_DBG_DOCKERS += $(DOCKER_SYNCD_BASE_DBG)
1616

17+
$(DOCKER_SYNCD_BASE)_VERSION = 1.0.0
18+
1719
$(DOCKER_SYNCD_BASE)_RUN_OPT += -v /host/warmboot:/var/warmboot
1820

1921
$(DOCKER_SYNCD_BASE)_BASE_IMAGE_FILES += bcmcmd:/usr/bin/bcmcmd

platform/cavium/docker-syncd-cavm-rpc.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_CAVM_RPC)
1717
endif
1818

1919
$(DOCKER_SYNCD_CAVM_RPC)_CONTAINER_NAME = syncd
20+
$(DOCKER_SYNCD_CAVM_RPC)_VERSION = 1.0.0
2021
$(DOCKER_SYNCD_CAVM_RPC)_RUN_OPT += --net=host --privileged -t
2122
$(DOCKER_SYNCD_CAVM_RPC)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf
2223
$(DOCKER_SYNCD_CAVM_RPC)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro

platform/cavium/docker-syncd-cavm.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ ifneq ($(ENABLE_SYNCD_RPC),y)
1616
SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_CAVM)
1717
endif
1818

19+
$(DOCKER_SYNCD_BASE)_VERSION = 1.0.0
20+
1921
$(DOCKER_SYNCD_CAVM)_CONTAINER_NAME = syncd
2022
$(DOCKER_SYNCD_CAVM)_RUN_OPT += --net=host --privileged -t
2123
$(DOCKER_SYNCD_CAVM)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf

platform/centec-arm64/docker-syncd-centec-rpc.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_CENTEC_RPC)
1818
endif
1919

2020
$(DOCKER_SYNCD_CENTEC_RPC)_CONTAINER_NAME = syncd
21+
$(DOCKER_SYNCD_CENTEC_RPC)_VERSION = 1.0.0
2122
$(DOCKER_SYNCD_CENTEC_RPC)_RUN_OPT += --privileged -t
2223
$(DOCKER_SYNCD_CENTEC_RPC)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf
2324
$(DOCKER_SYNCD_CENTEC_RPC)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro

platform/centec-arm64/docker-syncd-centec.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ $(DOCKER_SYNCD_BASE)_DBG_DEPENDS += $(SYNCD_DBG) \
1010
$(LIBSAIMETADATA_DBG) \
1111
$(LIBSAIREDIS_DBG)
1212

13+
$(DOCKER_SYNCD_BASE)_VERSION = 1.0.0
1314
$(DOCKER_SYNCD_BASE)_RUN_OPT += -v /host/warmboot:/var/warmboot
1415
$(DOCKER_SYNCD_CENTEC)_RUN_OPT += --privileged -t
1516
$(DOCKER_SYNCD_CENTEC)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf

platform/centec/docker-syncd-centec-rpc.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_CENTEC_RPC)
1818
endif
1919

2020
$(DOCKER_SYNCD_CENTEC_RPC)_CONTAINER_NAME = syncd
21+
$(DOCKER_SYNCD_CENTEC_RPC)_VERSION = 1.0.0
2122
$(DOCKER_SYNCD_CENTEC_RPC)_RUN_OPT += --privileged -t
2223
$(DOCKER_SYNCD_CENTEC_RPC)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf
2324
$(DOCKER_SYNCD_CENTEC_RPC)_RUN_OPT += -v /var/run/docker-syncd:/var/run/sswsyncd

0 commit comments

Comments
 (0)