Add memo-required flows for Dapp + Normal send #2400

leofelix077 · 2025-11-21T13:40:33Z

normal-memo-send.mov

dapp-memo-send.mov

memo-max-bytes-local-validation.mov

* upgrade to yarn 2 and use resolutions to block vulnerable package versions (#2239) * upgrade to yarn 2 and use resolutions to block vulnerable package versions * rm deprecated .yarnrc * rm yarnpath * try committing yarn binary to repo * try corepack enable for gha * update run tests cmd * rm yarnpath * rm npm i yarn * update all pipelines * rm superfluous history types * ensure invoke host function tx shows contract parameters (#2243) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * Bugfix/rm auth param names (#2244) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op (#2246) * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * Revert "add issuer for changeTrust op (#2246)" (#2247) This reverts commit 19c8a68. * Bugfix/add issuer for changetrust (#2249) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * cache account balances and poll for updates * fix CI tests * rm `force:true` which was causing action to happen too fast * do a fresh balance fetch on account/network change * first pass at async history * pr comments * allow for history caching * add more sentry tracking for Account and Wallets views (#2268) * add more sentry tracking for Account and Wallets views * adding more sentry reporting * gracefully degrade on errors from Blockaid (#2269) * gracefully degrade on errors from Blockaid * should not be necessary to skip dapp scanning on custom network * rm extra dep * add a test for persisting configurations in the send flow (#2271) * add a test for persisting configurations in the send flow * rm logs and update muxed acct; lower xlm payment * rm slow loading simulation * handle missing scan-tx result; add disabled state for Confirm Anyway (#2272) * handle missing scan-tx result; add disabled state for Confirm Anyway * assertions to show correct confirm button on Blockaid error * add cache for balances to ensure we do a fresh lookup when needed (#2275) * add cache for balances to ensure we do a fresh lookup when needed * add try...catch to token-prices polling * rm log * only dispatch saveBalancesForAccount when fresh data has been fetched * adjust test to wait for UI change * replace yarn setup with just yarn * rm unnecessary return * clear token details on redux clear action * make history row construction async and check for redux state for updates * add tests for assetdetails * increase timeout for flakey test * pr comments * refresh account history every time account balances refresh

* check for updated appdata before showing password modal * update error msg * rm unused redirect logic

* move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments

* skip blockaid scan on first fetch of account-balances * rm stub change * rm more stubs * rm log * add comments and update boolean naming

* add button to copy address from dropdown * Added translations * revert translation file changes * revert translation file changes * Added translations * revert changes to translation files * move copy address button to first dropdown position

* scroll on long strings; pretty print json * rm log * add correct snapshot for json message * rm log * finish comment * add error case for JSON * don't use carat for lib * update yarn.lock * move scrollbar to btm of container; reduce json font size * update snapshot

* re-searching so should abort any in flight API requests * add comment * fix test name * make test more reliable * add check for correct search results * fix jest locator

* adds SelectionTile and AddressTile, updates nav flows to match updates. Adds query parameter for default values in send flow * Added translations * adds address tile and uses it in swap flow, tweaks selection tile styles * adds unit tests for new tile components * Added translations * updates swap navigation flow to match updates, updates tests flows to match * updates back icon for send and swap steps, fixes bad test references * tweaks locator in address tile tests * adds store state to asset tile tests, removes asset icon mock * updates SelectionTile prop name, adds isSuspicious prop for AssetTile * adds placeholder value in TokenList for missing token USD value * uses real IdenticonImg in address tile unit tests * adds query param validation for send and swap flow * Update extension/src/popup/views/SendPayment/index.tsx Co-authored-by: Cássio Marcos Goulart <[email protected]> * adds missing import * adds class for tile icon --------- Co-authored-by: Cássio Marcos Goulart <[email protected]>

* adds send and swap buttons to asset detail view * uses secondary button styles * removes run snapshots job (#2355) * release/5.35.4 (#2354) * upgrade to ledger-hq/hw-transport-webhid (#2350) * upgrade to ledger-hq/hw-transport-webhid * add tests * add ledger support for new trustline flow (#2352) * upgrade to ledger-hq/hw-transport-webhid * add ledger support for new trustline flow * only re-fetch balances if we were successful * test for fetching balances on success * add reset spys * adjust spacing at top of hw wallet modal * Now that `Done` button properly shows, click it in tests (#2356) * skip flakey test * skip flakey test * renames local vars to follow convention * adds tests for LP share and tweaks LP title * adds links with query params for asset detail CTAs --------- Co-authored-by: Piyal Basu <[email protected]>

* only fetch asset list data if needed * correctly show icon loading state

* adds SAC detection when changing trust in the add and remove token flows * updates arg signature for isAssetSac

# Conflicts: # extension/src/popup/locales/en/translation.json # extension/src/popup/locales/pt/translation.json

* cache token prices and batch loading wallets * use similar methodology for token price and account balance caching * fix loading state trigger * fix tests * use helper for cache clearing * set isFetchingTokenPrices to false in catch handler * rollback error change

* load backend settings async on Account view * rm console.logs

* use ledger-key/accounts endpoint for home domains * fix tests * create generic ledger key account helper; add tests * rm unneeded data-test prop * rm unused import * [CHORE] git process updates (#2361) * moves the add translations hook to the pre commit stage, removes standalone translations commit * adds script to update app version, removes version update from submit production action, adds update version step to test run action for release branches * removes version input, now uses package version * fetch asset domains in one calls * fix tests * cache home domains while iterating over account history rows * fitler non-G keys * rm .only * fix test param * PR comments --------- Co-authored-by: aristides <[email protected]>

) * makes send swap buttons stay in the container in full screen mode * add a pause to make sure flakey e2e test has time to save changes

…ature/check-memo-required-on-send

.github/workflows/deployFreighterApiBeta.yml

…ature/check-memo-required-on-send

aristidesstaffieri · 2025-11-21T15:57:21Z

@leofelix077 it looks like this state should be within a view container in order to respect the max width in full screen mode. Typically, for the labels with the right facing caret we have made the interaction slide right to a pane within the bottom sheet itself. The transaction details label or the blockaid labels when signing a transaction should be good references for this.

* use redux selector for allAccounts to properly update rename * add longer timeout for flakey btn

…ature/check-memo-required-on-send

leofelix077 · 2025-11-21T20:06:49Z

Screen.Recording.2025-11-21.at.14.37.06.mov

…ature/check-memo-required-on-send

piyalbasu · 2025-11-28T16:04:50Z

extension/e2e-tests/onboarding.test.ts

  for (let i = 0; i < shuffledWords.length; i++) {
-    await page.getByLabel(shuffledWords[i]).check({ force: true });
+    // Use nth() to handle duplicate labels by selecting the first matching element
+    await page.getByLabel(shuffledWords[i]).first().check({ force: true });


Hm, does this work in the case of duped words? I would think from this code it would never select the 2nd instance of a word so if the phrase was "foo bar bar", it would end up just selecting the first instance of "bar" and it would try to validate "foo bar", which would fail

piyalbasu · 2025-11-28T16:36:45Z

extension/src/popup/helpers/useValidateTransactionMemo.ts

+   * Effect to parse XDR and set initial memo validation state
+   * Runs when XDR, network, or validation settings change
+   */
+  useEffect(() => {


I think you should be able to consolidate these next 2 useEffect calls - they seem duplicative. You should be able to just call checkIsMemoRequired after you build the xdr and set hasMemo`

piyalbasu · 2025-11-28T16:38:14Z

extension/src/popup/helpers/useValidateTransactionMemo.ts

+    setIsMemoMissing(true);
+    setIsValidatingMemo(false);
+
+    if (!shouldValidateMemo) {


NIt: I think we can also combine these next 2 if statements - if (!shouldValidateMemo || (!xdr || !networkDetails)) since they do the same thing

piyalbasu · 2025-11-28T16:43:03Z

extension/src/popup/views/SignTransaction/index.tsx

+                          : t("None")}
+                      </span>
+                    </div>
+                  </div>


I think this makes sense - but the Figma design actually doesn't include the memo here. It shows it on the Transaction Details view. Let's check with @sdfcharles to see what he thinks about adding the memo here

piyalbasu · 2025-11-28T17:25:09Z

extension/src/popup/components/sendPayment/SendAmount/index.tsx

+                // Regenerate transaction XDR with new memo (now reads memo from Redux state inside fetchData)
+                await fetchSimulationData();
+                // Reopen review sheet after memo is saved and XDR is regenerated
+                setIsReviewingTx(true);


Hm, why automatically open this review sheet here? As a user, I would expect this to come up only after I click Review Send. It's also a bit jarring because editing the fee doesn't open the review sheet - it's just editing the memo.

I think we should maintain the original UX of the user needing to click Review Send to get to the review sheet

Also, I'm noticing a bug where if I'm sending to a memo required address, if I enter a memo, I don't see the memo warning (great!), but if I go back and clear the memo, I can get past the memo warning

piyalbasu · 2025-11-28T17:31:24Z

Let's also add some tests for this functionality

piyalbasu and others added 23 commits October 7, 2025 15:45

check for updated appdata before showing password modal (#2300)

b61ec65

* check for updated appdata before showing password modal * update error msg * rm unused redirect logic

stringify errors rather than using cause (#2302)

91a49a5

Feature/move icons to own hook (#2308)

cc130fc

* move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments

skip blockaid scan on first fetch of account-balances (#2310)

c50cbc1

* skip blockaid scan on first fetch of account-balances * rm stub change * rm more stubs * rm log * add comments and update boolean naming

Merge branch 'master' into release/5.36.0

89b00b0

Merge branch 'master' into release/5.36.0

9218e3f

re-searching so should abort any in flight API requests (#2323)

077117e

* re-searching so should abort any in flight API requests * add comment * fix test name * make test more reliable * add check for correct search results * fix jest locator

only fetch asset list data if needed (#2369)

5199754

* only fetch asset list data if needed * correctly show icon loading state

[BUG] SAC token management improvements (#2374)

cdafa95

* adds SAC detection when changing trust in the add and remove token flows * updates arg signature for isAssetSac

Merge branch 'master' into release/5.36.0

85014fb

# Conflicts: # extension/src/popup/locales/en/translation.json # extension/src/popup/locales/pt/translation.json

load backend settings async on Account view (#2381)

6268562

* load backend settings async on Account view * rm console.logs

update version numbers for release

9a0dd5e

rm unnecessary calls to make flows even faster (#2391)

0aed2a4

makes send swap buttons stay in the container in full screen mode (#2392

1e8117a

) * makes send swap buttons stay in the container in full screen mode * add a pause to make sure flakey e2e test has time to save changes

add v1 of memo-required flow for transaction confirmation

d50e25b

adjust memo required flow for dapp and tx rebuild

631356b

leofelix077 requested review from aristidesstaffieri and piyalbasu November 21, 2025 13:40

leofelix077 self-assigned this Nov 21, 2025

leofelix077 added the don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review label Nov 21, 2025

leofelix077 changed the title ~~Feature/check memo required on send~~ Add memo-required flows for Dapp + Normal send Nov 21, 2025

leofelix077 added 2 commits November 21, 2025 10:53

add memo max bytes error handling

f4bb26b

update transaction loose text strings

37ab418

Merge branch 'release/5.36.0' of github.com:stellar/freighter into fe…

63ddc20

…ature/check-memo-required-on-send

leofelix077 commented Nov 21, 2025

View reviewed changes

.github/workflows/deployFreighterApiBeta.yml Outdated Show resolved Hide resolved

leofelix077 mentioned this pull request Nov 21, 2025

Add error handling for Search Asset results #2389

Open

piyalbasu and others added 2 commits November 21, 2025 10:52

Merge branch 'master' into release/5.36.0

bd6034d

Merge branch 'release/5.36.0' of github.com:stellar/freighter into fe…

2b20b9d

…ature/check-memo-required-on-send

adjust memo required on revalidation and add a container for message

ad3091e

leofelix077 marked this pull request as draft November 21, 2025 17:28

leofelix077 added the don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review label Nov 21, 2025

leofelix077 and others added 4 commits November 21, 2025 14:38

update memo-required flow to slide from right

4e74e54

update translation keys and memo required panes

619a4af

use redux selector for allAccounts to properly update rename (#2403)

1f3710d

* use redux selector for allAccounts to properly update rename * add longer timeout for flakey btn

Merge branch 'release/5.36.0' of github.com:stellar/freighter into fe…

dc88115

…ature/check-memo-required-on-send

leofelix077 closed this Nov 21, 2025

fix unit tests

7d52b3e

leofelix077 reopened this Nov 21, 2025

leofelix077 removed the don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review label Nov 24, 2025

leofelix077 marked this pull request as ready for review November 24, 2025 14:22

Base automatically changed from release/5.36.0 to master November 24, 2025 20:31

leofelix077 closed this Nov 25, 2025

leofelix077 reopened this Nov 26, 2025

leofelix077 changed the base branch from master to release/5.37.0 November 26, 2025 13:48

Merge branch 'release/5.37.0' of github.com:stellar/freighter into fe…

1e9be95

…ature/check-memo-required-on-send

piyalbasu reviewed Nov 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add memo-required flows for Dapp + Normal send #2400

Add memo-required flows for Dapp + Normal send #2400

Uh oh!

leofelix077 commented Nov 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

aristidesstaffieri commented Nov 21, 2025

Uh oh!

leofelix077 commented Nov 21, 2025

Uh oh!

piyalbasu Nov 28, 2025

Uh oh!

piyalbasu Nov 28, 2025

Uh oh!

piyalbasu Nov 28, 2025

Uh oh!

piyalbasu Nov 28, 2025

Uh oh!

piyalbasu Nov 28, 2025 •

edited

Loading

Uh oh!

piyalbasu Nov 28, 2025

Uh oh!

piyalbasu commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add memo-required flows for Dapp + Normal send #2400

Are you sure you want to change the base?

Add memo-required flows for Dapp + Normal send #2400

Uh oh!

Conversation

leofelix077 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

aristidesstaffieri commented Nov 21, 2025

Uh oh!

leofelix077 commented Nov 21, 2025

Uh oh!

piyalbasu Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leofelix077 commented Nov 21, 2025 •

edited

Loading

piyalbasu Nov 28, 2025 •

edited

Loading