Skip to content

ShellStream.Expect returns string end with matched text #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

ShellStream.Expect returns string end with matched text #990

wants to merge 4 commits into from

Conversation

@hhuang2013
Copy link

@hhuang2013 hhuang2013 commented Aug 5, 2022

Modify ShellStream.Expect to trim string after matched text and process byte count of return string.

This PR may solve #383 and #454

@hhuang2013 hhuang2013 requested a review from drieseng as a code owner August 5, 2022 07:05
@WojciechNagorski WojciechNagorski added this to the vNext milestone Oct 7, 2023
@WojciechNagorski
Copy link
Collaborator

WojciechNagorski commented Oct 7, 2023

I want to fix ShellStream in next version.

Merge remote-tracking branch 'upstream/develop' into develop
6ba85be 
# Conflicts:
#	src/Renci.SshNet/ShellStream.cs
@jscarle
Copy link
Contributor

jscarle commented Feb 13, 2024

This PR can be closed as this was adressed by #1207, #1315, and #1319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hhuang2013 @WojciechNagorski @jscarle