Skip to content

[Zlib] Falls back to use BouncyCastle if BCL doesn't support #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2024
Merged

[Zlib] Falls back to use BouncyCastle if BCL doesn't support #1453

merged 4 commits into from
Jul 25, 2024

Conversation

@scott-xu
Copy link
Collaborator

@scott-xu scott-xu commented Jul 21, 2024 •
edited
Loading

No description provided.

WojciechNagorski
WojciechNagorski requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't run .NET Framework 4.8 test on Linux, can you?

appveyor.yml
- echo build
- dotnet build -f net8.0 -c Debug test/Renci.SshNet.Tests/Renci.SshNet.Tests.csproj
- dotnet build -f net8.0 -c Debug test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj
- dotnet build -f net48 -c Debug test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj
Copy link
Collaborator

@WojciechNagorski WojciechNagorski Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you run .NET Framework on Linux? :) You should run it on Windows.

appveyor.yml
- sh: dotnet test -f net8.0 -c Debug --no-restore --no-build --results-directory artifacts --logger Appveyor --logger "console;verbosity=normal" --logger "liquid.md;LogFileName=linux_unit_test_net_8_report.md" -p:CollectCoverage=true -p:CoverletOutputFormat=cobertura -p:CoverletOutput=../../artifacts/linux_unit_test_net_8_coverage.xml test/Renci.SshNet.Tests/Renci.SshNet.Tests.csproj
- sh: echo "Run integration tests"
- sh: dotnet test -f net8.0 -c Debug --no-restore --no-build --results-directory artifacts --logger Appveyor --logger "console;verbosity=normal" --logger "liquid.md;LogFileName=linux_integration_test_net_8_report.md" -p:CollectCoverage=true -p:CoverletOutputFormat=cobertura -p:CoverletOutput=../../artifacts/linux_integration_test_net_8_coverage.xml test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj
- sh: dotnet test -f net48 -c Debug --no-restore --no-build --results-directory artifacts --logger Appveyor --logger "console;verbosity=normal" --logger "liquid.md;LogFileName=linux_integration_test_net_48_report.md" -p:CollectCoverage=true -p:CoverletOutputFormat=cobertura -p:CoverletOutput=../../artifacts/linux_integration_test_net_48_coverage.xml --filter Name~Zlib test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj
Copy link
Collaborator

@WojciechNagorski WojciechNagorski Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET Framework 4.8 on Linux.

@scott-xu
Copy link
Collaborator Author

scott-xu commented Jul 23, 2024

That's a very good question. I don't know why but the CI works.

@scott-xu
Copy link
Collaborator Author

scott-xu commented Jul 23, 2024

It might be based on Mono.

@scott-xu
Copy link
Collaborator Author

scott-xu commented Jul 23, 2024 •
edited
Loading

Here's CI output

dotnet test -f net48 -c Debug --no-restore --no-build --results-directory artifacts --logger Appveyor --logger "console;verbosity=normal" --logger "liquid.md;LogFileName=linux_integration_test_net_48_report.md" -p:CollectCoverage=true -p:CoverletOutputFormat=cobertura -p:CoverletOutput=../../artifacts/linux_integration_test_net_48_coverage.xml --filter Name~Zlib test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj
Test run for /home/appveyor/projects/ssh-net/test/Renci.SshNet.IntegrationTests/bin/Debug/net48/Renci.SshNet.IntegrationTests.dll (.NETFramework,Version=v4.8)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
Appveyor.TestLogger: Logging to http://localhost:42353/
A total of 1 test files matched the specified pattern.
  Passed ZlibOpenSsh [596 ms]
Appveyor.TestLogger: 1 test results reported (1 enqueued).
Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 20.7936 Seconds
Saved report to: linux_integration_test_net_48_report.md
Calculating coverage result...
  Generating report '../../artifacts/linux_integration_test_net_48_coverage.net48.xml'
+--------------------------------+--------+--------+--------+
| Module                         | Line   | Branch | Method |
+--------------------------------+--------+--------+--------+
| Renci.SshNet                   | 17.89% | 12.91% | 24.19% |
+--------------------------------+--------+--------+--------+
| Renci.SshNet.TestTools.OpenSSH | 0%     | 0%     | 0%     |
+--------------------------------+--------+--------+--------+
+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 17.47% | 12.16% | 23.54% |
+---------+--------+--------+--------+
| Average | 8.94%  | 6.45%  | 12.09% |
+---------+--------+--------+--------+

@WojciechNagorski
Copy link
Collaborator

WojciechNagorski commented Jul 23, 2024

You're right. There is mono https://www.appveyor.com/docs/linux-images-software/

WojciechNagorski
WojciechNagorski approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WojciechNagorski WojciechNagorski merged commit c614f54 into sshnet:develop Jul 25, 2024
@scott-xu scott-xu deleted the bc_zlib branch July 25, 2024 11:40
@scott-xu scott-xu mentioned this pull request Aug 14, 2024
Closed
@scott-xu scott-xu changed the title Zlib compression uses BouncyCastle as a fallback if BCL does not support [Zlib] Falls back to use BouncyCastle if BCL does not support Aug 24, 2024
@scott-xu scott-xu changed the title [Zlib] Falls back to use BouncyCastle if BCL does not support [Zlib] Falls back to use BouncyCastle if BCL doesn't support Aug 24, 2024
@Rob-Hague Rob-Hague mentioned this pull request Sep 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WojciechNagorski WojciechNagorski WojciechNagorski approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@Rob-Hague Rob-Hague Awaiting requested review from Rob-Hague Rob-Hague is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scott-xu @WojciechNagorski