Skip to content

[AesGcm] Falls back to use BouncyCastle if BCL doesn't support #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 19, 2024
Merged

[AesGcm] Falls back to use BouncyCastle if BCL doesn't support #1450

merged 23 commits into from
Aug 19, 2024

Conversation

@scott-xu
Copy link
Collaborator

@scott-xu scott-xu commented Jul 21, 2024

No description provided.

@scott-xu scott-xu changed the title [AesGcmCipher] Use BouncyCastle as a fallback if BCL does not support. AesGcmCipher uses BouncyCastle as a fallback if BCL does not support. Jul 21, 2024
@scott-xu
Copy link
Collaborator Author

scott-xu commented Jul 30, 2024

This PR's code structure is very similar with AesCipher's implementation as well. Ready to review and merge @Rob-Hague @WojciechNagorski

@scott-xu scott-xu mentioned this pull request Aug 14, 2024
Closed
@Rob-Hague Rob-Hague merged commit ebb31bb into sshnet:develop Aug 19, 2024
@scott-xu scott-xu deleted the bc_aesgcm branch August 19, 2024 12:49
@scott-xu scott-xu changed the title AesGcmCipher uses BouncyCastle as a fallback if BCL does not support. [AesGcm] Falls back to use BouncyCastle if BCL does not support Aug 24, 2024
@scott-xu scott-xu changed the title [AesGcm] Falls back to use BouncyCastle if BCL does not support [AesGcm] Falls back to use BouncyCastle if BCL doesn't support Aug 24, 2024
@scott-xu scott-xu mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rob-Hague Rob-Hague Rob-Hague approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scott-xu @Rob-Hague @WojciechNagorski