Skip to content

make ConnectShouldActivateKeepAliveIfSessionIs test less flaky #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2024
Merged

make ConnectShouldActivateKeepAliveIfSessionIs test less flaky #1410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd4bdda
make ConnectShouldActivateKeepAliveIfSessionIs test less flaky
mus65 May 20, 2024
662af82
fix net462 build
mus65 May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...enci.SshNet.Tests/Classes/BaseClientTest_NotConnected_KeepAliveInterval_NotNegativeOne.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ public void ConnectShouldActivateKeepAliveIfSessionIs()

_client.Connect();

// allow keep-alive to be sent twice
Thread.Sleep(250);
// allow keep-alive to be sent at least twice with some margin for error
Thread.Sleep(5 * (int)_keepAliveInterval.TotalMilliseconds);

// Exactly two keep-alives should be sent
SessionMock.Verify(p => p.TrySendMessage(It.IsAny<IgnoreMessage>()), Times.Exactly(2));
// At least two keep-alives should be sent
SessionMock.Verify(p => p.TrySendMessage(It.IsAny<IgnoreMessage>()), Times.AtLeast(2));
}

private class MyClient : BaseClient
Expand Down