Skip to content

fix flaky Sftp_BeginUploadFile test #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2024
Merged

fix flaky Sftp_BeginUploadFile test #1402

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f66c15
fix flaky Sftp_BeginUploadFile test
mus65 May 17, 2024
70d03fd
use ManualResetEventSlim
mus65 May 17, 2024
45bd252
Merge branch 'develop' into fixbeginuploadfiletest
Rob-Hague May 17, 2024
d7c5789
Merge branch 'develop' into fixbeginuploadfiletest
Rob-Hague May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/Renci.SshNet.IntegrationTests/SftpTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,13 @@ public void Sftp_BeginUploadFile()
using (var memoryStream = new MemoryStream(Encoding.ASCII.GetBytes(content)))
{
IAsyncResult asyncResultCallback = null;
using var callbackCalled = new ManualResetEventSlim(false);

var asyncResult = client.BeginUploadFile(memoryStream, remoteFile, ar => asyncResultCallback = ar);
var asyncResult = client.BeginUploadFile(memoryStream, remoteFile, ar =>
{
asyncResultCallback = ar;
callbackCalled.Set();
});

Assert.IsTrue(asyncResult.AsyncWaitHandle.WaitOne(10000));

Expand All @@ -145,6 +150,8 @@ public void Sftp_BeginUploadFile()
Assert.IsFalse(sftpUploadAsyncResult.CompletedSynchronously);
Assert.AreEqual(expectedByteCount, sftpUploadAsyncResult.UploadedBytes);

Assert.IsTrue(callbackCalled.Wait(10000));

// check async result callback
var sftpUploadAsyncResultCallback = asyncResultCallback as SftpUploadAsyncResult;
Assert.IsNotNull(sftpUploadAsyncResultCallback);
Expand Down