From 8aa0dc6d2733c8a46db0e315373fa208a38cd0a5 Mon Sep 17 00:00:00 2001 From: Rushaway Date: Tue, 3 Mar 2026 09:36:14 +0100 Subject: [PATCH 1/3] fix(ripext): memory leak --- addons/sourcemod/scripting/FixNetPublicAdr.sp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/addons/sourcemod/scripting/FixNetPublicAdr.sp b/addons/sourcemod/scripting/FixNetPublicAdr.sp index 30630b2..a4901ae 100644 --- a/addons/sourcemod/scripting/FixNetPublicAdr.sp +++ b/addons/sourcemod/scripting/FixNetPublicAdr.sp @@ -12,7 +12,7 @@ public Plugin myinfo = name = "FixNetPublicAddr", author = "maxime1907, .Rushaway", description = "Add/Edit convar net_public_adr for servers behind NAT/DHCP", - version = "1.1.1", + version = "1.1.2", url = "" }; @@ -81,7 +81,11 @@ void OnPublicIPReceived(HTTPResponse response, any value) return; JSONObject jsonIP = view_as(response.Data); + if (jsonIP == null) + return; + jsonIP.GetString("ip", g_sPublicIPAddress, sizeof(g_sPublicIPAddress)); + delete jsonIP; g_cvNetPublicAddr.SetString(g_sPublicIPAddress, false, true); } From 37ea624f11747fd9b371ffe3616bf8f8eef04e67 Mon Sep 17 00:00:00 2001 From: Rushaway Date: Tue, 3 Mar 2026 09:40:27 +0100 Subject: [PATCH 2/3] Log error on JSON parsing failure in FixNetPublicAdr Added error logging for JSON parsing failure. --- addons/sourcemod/scripting/FixNetPublicAdr.sp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/addons/sourcemod/scripting/FixNetPublicAdr.sp b/addons/sourcemod/scripting/FixNetPublicAdr.sp index a4901ae..657fb1e 100644 --- a/addons/sourcemod/scripting/FixNetPublicAdr.sp +++ b/addons/sourcemod/scripting/FixNetPublicAdr.sp @@ -82,7 +82,11 @@ void OnPublicIPReceived(HTTPResponse response, any value) JSONObject jsonIP = view_as(response.Data); if (jsonIP == null) + { + LogError("Failed to parse JSON response from endpoint, fallback to hostip"); + GetPublicIPFromHostIP(); return; + } jsonIP.GetString("ip", g_sPublicIPAddress, sizeof(g_sPublicIPAddress)); delete jsonIP; From 6ac636a00be17ee585a8bb5ae8729a286040f1c8 Mon Sep 17 00:00:00 2001 From: Rushaway Date: Tue, 3 Mar 2026 10:06:20 +0100 Subject: [PATCH 3/3] Remove unnecessary delete of jsonIP --- addons/sourcemod/scripting/FixNetPublicAdr.sp | 1 - 1 file changed, 1 deletion(-) diff --git a/addons/sourcemod/scripting/FixNetPublicAdr.sp b/addons/sourcemod/scripting/FixNetPublicAdr.sp index 657fb1e..4d934ab 100644 --- a/addons/sourcemod/scripting/FixNetPublicAdr.sp +++ b/addons/sourcemod/scripting/FixNetPublicAdr.sp @@ -89,7 +89,6 @@ void OnPublicIPReceived(HTTPResponse response, any value) } jsonIP.GetString("ip", g_sPublicIPAddress, sizeof(g_sPublicIPAddress)); - delete jsonIP; g_cvNetPublicAddr.SetString(g_sPublicIPAddress, false, true); }