Improve JdbcUserDetailsManager.userExists method

Author: tIster12

core/src/main/java/org/springframework/security/provisioning/JdbcUserDetailsManager.java

@@ -75,7 +75,7 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
 
 	public static final String DEF_DELETE_USER_AUTHORITIES_SQL = "delete from authorities where username = ?";
 
-	public static final String DEF_USER_EXISTS_SQL = "select username from users where username = ?";
+	public static final String DEF_USER_EXISTS_SQL = "select count(*) from users where username = ?";
 
 	public static final String DEF_CHANGE_PASSWORD_SQL = "update users set password = ? where username = ?";
 
@@ -300,13 +300,18 @@ protected Authentication createNewAuthentication(Authentication currentAuth, Str
 
 	@Override
 	public boolean userExists(String username) {
-		List<String> users = getJdbcTemplate().queryForList(this.userExistsSql, new String[] { username },
-				String.class);
-		if (users.size() > 1) {
-			throw new IncorrectResultSizeDataAccessException("More than one user found with name '" + username + "'",
-					1);
+		@SuppressWarnings("ConstantConditions")
+		int usersCount = getJdbcTemplate().queryForObject(
+				this.userExistsSql,
+				Integer.class,
+				username
+		);
+		if (usersCount > 1) {
+			throw new IncorrectResultSizeDataAccessException(
+					"["+ usersCount + "] users found with name '" + username + "', expected 1", 1
+			);
 		}
-		return users.size() == 1;
+		return usersCount == 1;
 	}
 
 	@Override

core/src/test/java/org/springframework/security/provisioning/JdbcUserDetailsManagerTests.java

@@ -185,6 +185,11 @@ public void userExistsReturnsFalseForNonExistentUsername() {
 		assertThat(this.manager.userExists("joe")).isFalse();
 	}
 
+	@Test
+	public void userExistsReturnsFalseForNullUsername() {
+		assertThat(this.manager.userExists(null)).isFalse();
+	}
+
 	@Test
 	public void userExistsReturnsTrueForExistingUsername() {
 		insertJoe();