Skip to content

Commit cd53be7

Browse files
committed
Comment out Java 17 matrix for sample tests
The Java 17 is not enough for ErrorProne: min is 21 The test Java version in the CI matrix is propagated to the main toolchain in project
1 parent 60df329 commit cd53be7

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

.github/workflows/check-samples.yml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -70,21 +70,21 @@ jobs:
7070
springPulsarVersion: "${{ needs.prerequisites.outputs.project_version }}"
7171
pulsarVersion: "${{ needs.prerequisites.outputs.pulsar_version }}"
7272
samplesTarget: ':runAllSampleTests'
73-
- javaVersion: 17
74-
springBootVersion: "${{ needs.prerequisites.outputs.boot_version }}"
75-
springPulsarVersion: "${{ needs.prerequisites.outputs.project_version }}"
76-
pulsarVersion: "${{ needs.prerequisites.outputs.pulsar_version }}"
77-
samplesTarget: ':runAllSampleTests'
78-
- javaVersion: 17
79-
springBootVersion: "${{ needs.prerequisites.outputs.boot_version }}"
80-
springPulsarVersion: "${{ needs.prerequisites.outputs.project_version }}"
81-
pulsarVersion: "3.3.8"
82-
samplesTarget: ':runAllSampleTests'
83-
- javaVersion: 17
84-
springBootVersion: "${{ needs.prerequisites.outputs.boot_version }}"
85-
springPulsarVersion: "${{ needs.prerequisites.outputs.project_version }}"
86-
pulsarVersion: "3.2.4"
87-
samplesTarget: ':runAllSampleTests'
73+
# - javaVersion: 17
74+
# springBootVersion: "${{ needs.prerequisites.outputs.boot_version }}"
75+
# springPulsarVersion: "${{ needs.prerequisites.outputs.project_version }}"
76+
# pulsarVersion: "${{ needs.prerequisites.outputs.pulsar_version }}"
77+
# samplesTarget: ':runAllSampleTests'
78+
# - javaVersion: 17
79+
# springBootVersion: "${{ needs.prerequisites.outputs.boot_version }}"
80+
# springPulsarVersion: "${{ needs.prerequisites.outputs.project_version }}"
81+
# pulsarVersion: "3.3.8"
82+
# samplesTarget: ':runAllSampleTests'
83+
# - javaVersion: 17
84+
# springBootVersion: "${{ needs.prerequisites.outputs.boot_version }}"
85+
# springPulsarVersion: "${{ needs.prerequisites.outputs.project_version }}"
86+
# pulsarVersion: "3.2.4"
87+
# samplesTarget: ':runAllSampleTests'
8888
runs-on: ubuntu-latest
8989
if: needs.prerequisites.outputs.runjobs
9090
steps:

0 commit comments

Comments
 (0)