Skip to content

GH-2302: Enable consumer seek only on matching group Id #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 25, 2024
+192 −8
Merged

GH-2302: Enable consumer seek only on matching group Id #3318

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3b3490f
GH-2302: Enable consumer seek only on matching group Id
bky373 Jun 18, 2024
a81a06d
Add groupId getter to ConsumerSeekCallback and remove match method
bky373 Jun 22, 2024
991bc8f
remove line for class
bky373 Jun 22, 2024
a724510
Resolve checkstyle violations and add missing copyright section, auth…
bky373 Jun 24, 2024
d7ce604
Drop `public` modifiers
bky373 Jun 24, 2024
2f3cdb7
Update "seek.adoc" and "whats-new.adoc"
bky373 Jun 24, 2024
f94938c
Restore dlt style in "whats-new.adoc"
bky373 Jun 24, 2024
1ef1ccd
Update "whats-new.adoc"
bky373 Jun 24, 2024
d79ea1a
Update "seek.adoc"
bky373 Jun 24, 2024
4248be5
Revert the existing javadocs
bky373 Jun 25, 2024
74a533a
Use consumerGroupId field instead
bky373 Jun 25, 2024
f1e15ce
Remove useless method
bky373 Jun 25, 2024
0b1aae4
Modify test
bky373 Jun 25, 2024
b34a610
Add assert
bky373 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...afka/src/test/java/org/springframework/kafka/listener/AbstractConsumerSeekAwareTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ void seekForSpecificGroup() throws Exception {
MultiGroupListener.latch2 = new CountDownLatch(2);

multiGroupListener.seekToBeginningForGroup("group2");
assertThat(MultiGroupListener.latch1.getCount()).isEqualTo(2);
assertThat(MultiGroupListener.latch2.await(10, TimeUnit.SECONDS)).isTrue();
assertThat(MultiGroupListener.latch1.await(100, TimeUnit.MICROSECONDS)).isFalse();
}

@EnableKafka
Expand Down