fix ignored exceptions

Vincent Potucek · Vincent Potucek · commit 1e3ec20392dc · 2025-06-13T11:55:32.000+02:00
Signed-off-by: Vincent Potucek &lt;vpotucek@me.com&gt;
diff --git a/spring-core/src/main/java/org/springframework/util/FileCopyUtils.java b/spring-core/src/main/java/org/springframework/util/FileCopyUtils.java
@@ -229,8 +229,7 @@ private static void close(Closeable closeable) {
 		try {
 			closeable.close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-test/src/main/java/org/springframework/mock/http/client/MockClientHttpResponse.java b/spring-test/src/main/java/org/springframework/mock/http/client/MockClientHttpResponse.java
@@ -100,8 +100,7 @@ public void close() {
 		try {
 			getBody().close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-web/src/main/java/org/springframework/http/client/HttpComponentsClientHttpResponse.java b/spring-web/src/main/java/org/springframework/http/client/HttpComponentsClientHttpResponse.java
@@ -89,8 +89,7 @@ public void close() {
 				this.httpResponse.close();
 			}
 		}
-		catch (IOException ex) {
-			// Ignore exception on close...
+		catch (IOException ignored) { exception on close...
 		}
 	}
 
diff --git a/spring-web/src/main/java/org/springframework/http/client/ReactorClientHttpResponse.java b/spring-web/src/main/java/org/springframework/http/client/ReactorClientHttpResponse.java
@@ -108,8 +108,7 @@ public void close() {
 			StreamUtils.drain(body);
 			body.close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-web/src/main/java/org/springframework/web/client/HttpMessageConverterExtractor.java b/spring-web/src/main/java/org/springframework/web/client/HttpMessageConverterExtractor.java
@@ -152,8 +152,7 @@ private static byte[] getResponseBody(ClientHttpResponse response) {
 		try {
 			return FileCopyUtils.copyToByteArray(response.getBody());
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 		return new byte[0];
 	}
diff --git a/spring-web/src/testFixtures/java/org/springframework/web/testfixture/http/client/MockClientHttpResponse.java b/spring-web/src/testFixtures/java/org/springframework/web/testfixture/http/client/MockClientHttpResponse.java
@@ -100,8 +100,7 @@ public void close() {
 		try {
 			getBody().close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/resource/ResourceHandlerUtils.java b/spring-webflux/src/main/java/org/springframework/web/reactive/resource/ResourceHandlerUtils.java
@@ -76,8 +76,7 @@ else if (location instanceof UrlResource) {
 			Assert.isTrue(path.endsWith(FOLDER_SEPARATOR) || path.endsWith(WINDOWS_FOLDER_SEPARATOR),
 					"Resource location does not end with slash: " + path);
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestPartMethodArgumentResolver.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestPartMethodArgumentResolver.java
@@ -191,8 +191,7 @@ void closeStreamIfNecessary(InputStream body) {
 		try {
 			body.close();
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHandlerUtils.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHandlerUtils.java
@@ -77,8 +77,7 @@ else if (location instanceof UrlResource) {
 			Assert.isTrue(path.endsWith(FOLDER_SEPARATOR) || path.endsWith(WINDOWS_FOLDER_SEPARATOR),
 					"Resource location does not end with slash: " + path);
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-websocket/src/main/java/org/springframework/web/socket/handler/BinaryWebSocketHandler.java b/spring-websocket/src/main/java/org/springframework/web/socket/handler/BinaryWebSocketHandler.java
@@ -41,8 +41,7 @@ protected void handleTextMessage(WebSocketSession session, TextMessage message)
 		try {
 			session.close(CloseStatus.NOT_ACCEPTABLE.withReason("Text messages not supported"));
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 
diff --git a/spring-websocket/src/main/java/org/springframework/web/socket/handler/TextWebSocketHandler.java b/spring-websocket/src/main/java/org/springframework/web/socket/handler/TextWebSocketHandler.java
@@ -41,8 +41,7 @@ protected void handleBinaryMessage(WebSocketSession session, BinaryMessage messa
 		try {
 			session.close(CloseStatus.NOT_ACCEPTABLE.withReason("Binary messages not supported"));
 		}
-		catch (IOException ex) {
-			// ignore
+		catch (IOException ignored) {
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -229,8 +229,7 @@ private static void close(Closeable closeable) {`
`229`	`229`	`try {`
`230`	`230`	`closeable.close();`
`231`	`231`	`}`
`232`		`- catch (IOException ex) {`
`233`		`- // ignore`
	`232`	`+ catch (IOException ignored) {`
`234`	`233`	`}`
`235`	`234`	`}`
`236`	`235`
Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,7 @@ public void close() {`
`100`	`100`	`try {`
`101`	`101`	`getBody().close();`
`102`	`102`	`}`
`103`		`- catch (IOException ex) {`
`104`		`- // ignore`
	`103`	`+ catch (IOException ignored) {`
`105`	`104`	`}`
`106`	`105`	`}`
`107`	`106`
Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,7 @@ public void close() {`
`89`	`89`	`this.httpResponse.close();`
`90`	`90`	`}`
`91`	`91`	`}`
`92`		`- catch (IOException ex) {`
`93`		`- // Ignore exception on close...`
	`92`	`+ catch (IOException ignored) { exception on close...`
`94`	`93`	`}`
`95`	`94`	`}`
`96`	`95`
Original file line number	Diff line number	Diff line change
`@@ -108,8 +108,7 @@ public void close() {`
`108`	`108`	`StreamUtils.drain(body);`
`109`	`109`	`body.close();`
`110`	`110`	`}`
`111`		`- catch (IOException ex) {`
`112`		`- // ignore`
	`111`	`+ catch (IOException ignored) {`
`113`	`112`	`}`
`114`	`113`	`}`
`115`	`114`
Original file line number	Diff line number	Diff line change
`@@ -152,8 +152,7 @@ private static byte[] getResponseBody(ClientHttpResponse response) {`
`152`	`152`	`try {`
`153`	`153`	`return FileCopyUtils.copyToByteArray(response.getBody());`
`154`	`154`	`}`
`155`		`- catch (IOException ex) {`
`156`		`- // ignore`
	`155`	`+ catch (IOException ignored) {`
`157`	`156`	`}`
`158`	`157`	`return new byte[0];`
`159`	`158`	`}`
Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ else if (location instanceof UrlResource) {`
`76`	`76`	`Assert.isTrue(path.endsWith(FOLDER_SEPARATOR) \|\| path.endsWith(WINDOWS_FOLDER_SEPARATOR),`
`77`	`77`	`"Resource location does not end with slash: " + path);`
`78`	`78`	`}`
`79`		`- catch (IOException ex) {`
`80`		`- // ignore`
	`79`	`+ catch (IOException ignored) {`
`81`	`80`	`}`
`82`	`81`	`}`
`83`	`82`
Original file line number	Diff line number	Diff line change
`@@ -191,8 +191,7 @@ void closeStreamIfNecessary(InputStream body) {`
`191`	`191`	`try {`
`192`	`192`	`body.close();`
`193`	`193`	`}`
`194`		`- catch (IOException ex) {`
`195`		`- // ignore`
	`194`	`+ catch (IOException ignored) {`
`196`	`195`	`}`
`197`	`196`	`}`
`198`	`197`
Original file line number	Diff line number	Diff line change
`@@ -77,8 +77,7 @@ else if (location instanceof UrlResource) {`
`77`	`77`	`Assert.isTrue(path.endsWith(FOLDER_SEPARATOR) \|\| path.endsWith(WINDOWS_FOLDER_SEPARATOR),`
`78`	`78`	`"Resource location does not end with slash: " + path);`
`79`	`79`	`}`
`80`		`- catch (IOException ex) {`
`81`		`- // ignore`
	`80`	`+ catch (IOException ignored) {`
`82`	`81`	`}`
`83`	`82`	`}`
`84`	`83`
Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,7 @@ protected void handleTextMessage(WebSocketSession session, TextMessage message)`
`41`	`41`	`try {`
`42`	`42`	`session.close(CloseStatus.NOT_ACCEPTABLE.withReason("Text messages not supported"));`
`43`	`43`	`}`
`44`		`- catch (IOException ex) {`
`45`		`- // ignore`
	`44`	`+ catch (IOException ignored) {`
`46`	`45`	`}`
`47`	`46`	`}`
`48`	`47`