Polish #39382
Closed
Polish #39382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkinsona
requested changes
Feb 2, 2024
Member
wilkinsona
left a comment
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks, @snicoll. List.of is all good. Our intention is that it's used "everywhere" other than for creating an empty list.
...boot/actuate/autoconfigure/endpoint/web/documentation/LoggersEndpointDocumentationTests.java
Outdated
Show resolved
Hide resolved
snicoll
force-pushed
the
polish-20240202
branch
from
6ac10e6 to
eab3aad
Compare
Closed
scottfrederick
pushed a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sure what we should do for
List.ofso let me know if you prefer to not have that.