Add extra check on connection state in AbstractCursorItemReader#doClose

fmbenhassine · fmbenhassine · commit e398c3ea6590 · 2020-03-18T21:48:46.000+01:00
Issue #868
diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/AbstractCursorItemReader.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/AbstractCursorItemReader.java
@@ -398,7 +398,7 @@ protected void doClose() throws Exception {
 		rs = null;
 		cleanupOnClose();
 
-		if(this.con != null) {
+		if(this.con != null && !this.con.isClosed()) {
 			this.con.setAutoCommit(this.initialConnectionAutoCommit);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ protected void doClose() throws Exception {`
`398`	`398`	`rs = null;`
`399`	`399`	`cleanupOnClose();`
`400`	`400`
`401`		`- if(this.con != null) {`
	`401`	`+ if(this.con != null && !this.con.isClosed()) {`
`402`	`402`	`this.con.setAutoCommit(this.initialConnectionAutoCommit);`
`403`	`403`	`}`
`404`	`404`