Enforce use of Bundler >= 2.4 #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make use of `install_if` in our appraisals. However, if you aren't using Bundler 2.4 then you can't generate any appraisal gemfiles. This commit enforces the correct version of Bundler by adding a check to the Gemfile itself. This isn't ideal, but we can't simply add `gem "bundler", "~> 2.4"` to the Gemfile because of the new-ish logic in Bundler which [automatically switches to the version of Bundler specified by the `BUNDLED WITH` section in the lockfile][1]. Unfortunately, we can't commit the lockfiles to the repo, so neither adding the `gem` line nor updating the `BUNDLED WITH` would work. [1]: https://bundler.io/blog/2022/01/23/bundler-v2-3.html
Collaborator
Author
|
Hmm. This might not be necessary after we remove old Rubies and Rails. Stand by... |
Collaborator
Author
|
Yup, we don't need this right now. Closing due to #187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make use of
install_ifin our appraisals. However, if you aren't using Bundler 2.4 then you can't generate any appraisal gemfiles.This commit enforces the correct version of Bundler by adding a check to the Gemfile itself. This isn't ideal, but we can't simply add
gem "bundler", "~> 2.4"to the Gemfile because of the new-ish logic in Bundler which automatically switches to the version of Bundler specified by theBUNDLED WITHsection in the lockfile. Unfortunately, we can't commit the lockfiles to the repo, so neither adding thegemline nor updating theBUNDLED WITHwould work.