Skip to content

Don't require active_record unless ActiveRecord is defined #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't require active_record unless ActiveRecord is defined #158

wants to merge 1 commit into from

Conversation

@sshaw
Copy link
Contributor

@sshaw sshaw commented Oct 18, 2022

This caused issues with Rails projects that did not use ActiveRecord

Let me know test-wise what to do, if anything.

@sshaw
Don't require active_record unless ActiveRecord is defined
29f50a7 
This caused issues with Rails projects that did not use ActiveRecord
@mcmire
Copy link
Collaborator

mcmire commented Mar 26, 2023

Hey, sorry for the long delay in responding to this PR. It turns out #112 was a duplicate of this, and I used the example there to come up with a test case and merged a fix, including your changes, in #188. Thank you!

@mcmire mcmire closed this Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sshaw @mcmire