Skip to content

Commit c208c01

Browse files
mcmiremcmire
committed
Block Rails 5.x Appraisals from installing on Ruby 3+
This is to match the GitHub Actions build config file.
1 parent ed95787 commit c208c01

8 files changed

+48
-44
lines changed

‎Appraisals‎

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,7 @@ appraisals = {
3939
gem "rspec", version
4040

4141
if with_rails
42-
# gem "rspec-core", version
43-
# gem "rspec-expectations", version
44-
# gem "rspec-mocks", version
45-
# gem "rspec-support", version
4642
gem "rspec-rails"
47-
# else
48-
# gem "rspec", version
4943
end
5044
},
5145
rspec_gte_3_10: proc { |with_rails|
@@ -54,23 +48,19 @@ appraisals = {
5448
gem "rspec", *version
5549

5650
if with_rails
57-
# gem "rspec-core", *version
58-
# gem "rspec-expectations", *version
59-
# gem "rspec-mocks", *version
60-
# gem "rspec-support", *version
6151
gem "rspec-rails"
62-
# else
63-
# gem "rspec", *version
6452
end
6553
},
6654
}
6755

68-
rails_appraisals = [
69-
:rails_5_0,
70-
:rails_5_1,
71-
:rails_5_2,
72-
:no_rails,
73-
]
56+
rails_appraisals = [:no_rails]
57+
58+
if Gem::Requirement.new("< 3").satisfied_by?(Gem::Version.new(RUBY_VERSION))
59+
rails_appraisals << :rails_5_0
60+
rails_appraisals << :rails_5_1
61+
rails_appraisals << :rails_5_2
62+
end
63+
7464
if Gem::Requirement.new(">= 2.5.0").satisfied_by?(Gem::Version.new(RUBY_VERSION))
7565
rails_appraisals << :rails_6_0
7666
end

‎gemfiles/rails_5_0_rspec_gte_3_10.gemfile.lock‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ GEM
5454
crass (~> 1.0.2)
5555
nokogiri (>= 1.5.9)
5656
method_source (1.0.0)
57-
mini_portile2 (2.4.0)
57+
mini_portile2 (2.5.1)
5858
minitest (5.14.2)
59-
nokogiri (1.10.10)
60-
mini_portile2 (~> 2.4.0)
59+
nokogiri (1.11.3)
60+
mini_portile2 (~> 2.5.0)
61+
racc (~> 1.4)
6162
optimist (3.0.1)
6263
parallel (1.19.2)
6364
parser (2.7.1.4)
@@ -70,6 +71,7 @@ GEM
7071
pry-byebug (3.9.0)
7172
byebug (~> 11.0)
7273
pry (~> 0.13.0)
74+
racc (1.5.2)
7375
rack (2.2.3)
7476
rack-test (0.6.3)
7577
rack (>= 1.0)
@@ -150,4 +152,4 @@ DEPENDENCIES
150152
warnings_logger
151153

152154
BUNDLED WITH
153-
2.1.4
155+
2.2.17

‎gemfiles/rails_5_0_rspec_lt_3_10.gemfile.lock‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ GEM
5454
crass (~> 1.0.2)
5555
nokogiri (>= 1.5.9)
5656
method_source (1.0.0)
57-
mini_portile2 (2.4.0)
57+
mini_portile2 (2.5.1)
5858
minitest (5.14.2)
59-
nokogiri (1.10.10)
60-
mini_portile2 (~> 2.4.0)
59+
nokogiri (1.11.3)
60+
mini_portile2 (~> 2.5.0)
61+
racc (~> 1.4)
6162
optimist (3.0.1)
6263
parallel (1.19.2)
6364
parser (2.7.1.4)
@@ -70,6 +71,7 @@ GEM
7071
pry-byebug (3.9.0)
7172
byebug (~> 11.0)
7273
pry (~> 0.13.0)
74+
racc (1.5.2)
7375
rack (2.2.3)
7476
rack-test (0.6.3)
7577
rack (>= 1.0)
@@ -150,4 +152,4 @@ DEPENDENCIES
150152
warnings_logger
151153

152154
BUNDLED WITH
153-
2.1.4
155+
2.2.17

‎gemfiles/rails_5_1_rspec_gte_3_10.gemfile.lock‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ GEM
5454
crass (~> 1.0.2)
5555
nokogiri (>= 1.5.9)
5656
method_source (1.0.0)
57-
mini_portile2 (2.4.0)
57+
mini_portile2 (2.5.1)
5858
minitest (5.14.2)
59-
nokogiri (1.10.10)
60-
mini_portile2 (~> 2.4.0)
59+
nokogiri (1.11.3)
60+
mini_portile2 (~> 2.5.0)
61+
racc (~> 1.4)
6162
optimist (3.0.1)
6263
parallel (1.19.2)
6364
parser (2.7.1.4)
@@ -70,6 +71,7 @@ GEM
7071
pry-byebug (3.9.0)
7172
byebug (~> 11.0)
7273
pry (~> 0.13.0)
74+
racc (1.5.2)
7375
rack (2.2.3)
7476
rack-test (1.1.0)
7577
rack (>= 1.0, < 3)
@@ -150,4 +152,4 @@ DEPENDENCIES
150152
warnings_logger
151153

152154
BUNDLED WITH
153-
2.1.4
155+
2.2.17

‎gemfiles/rails_5_1_rspec_lt_3_10.gemfile.lock‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ GEM
5454
crass (~> 1.0.2)
5555
nokogiri (>= 1.5.9)
5656
method_source (1.0.0)
57-
mini_portile2 (2.4.0)
57+
mini_portile2 (2.5.1)
5858
minitest (5.14.2)
59-
nokogiri (1.10.10)
60-
mini_portile2 (~> 2.4.0)
59+
nokogiri (1.11.3)
60+
mini_portile2 (~> 2.5.0)
61+
racc (~> 1.4)
6162
optimist (3.0.1)
6263
parallel (1.19.2)
6364
parser (2.7.1.4)
@@ -70,6 +71,7 @@ GEM
7071
pry-byebug (3.9.0)
7172
byebug (~> 11.0)
7273
pry (~> 0.13.0)
74+
racc (1.5.2)
7375
rack (2.2.3)
7476
rack-test (1.1.0)
7577
rack (>= 1.0, < 3)
@@ -150,4 +152,4 @@ DEPENDENCIES
150152
warnings_logger
151153

152154
BUNDLED WITH
153-
2.1.4
155+
2.2.17

‎gemfiles/rails_5_2_rspec_gte_3_10.gemfile.lock‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ GEM
5454
crass (~> 1.0.2)
5555
nokogiri (>= 1.5.9)
5656
method_source (1.0.0)
57-
mini_portile2 (2.4.0)
57+
mini_portile2 (2.5.1)
5858
minitest (5.14.2)
59-
nokogiri (1.10.10)
60-
mini_portile2 (~> 2.4.0)
59+
nokogiri (1.11.3)
60+
mini_portile2 (~> 2.5.0)
61+
racc (~> 1.4)
6162
optimist (3.0.1)
6263
parallel (1.19.2)
6364
parser (2.7.1.4)
@@ -70,6 +71,7 @@ GEM
7071
pry-byebug (3.9.0)
7172
byebug (~> 11.0)
7273
pry (~> 0.13.0)
74+
racc (1.5.2)
7375
rack (2.2.3)
7476
rack-test (1.1.0)
7577
rack (>= 1.0, < 3)
@@ -150,4 +152,4 @@ DEPENDENCIES
150152
warnings_logger
151153

152154
BUNDLED WITH
153-
2.1.4
155+
2.2.17

‎gemfiles/rails_5_2_rspec_lt_3_10.gemfile.lock‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ GEM
5454
crass (~> 1.0.2)
5555
nokogiri (>= 1.5.9)
5656
method_source (1.0.0)
57-
mini_portile2 (2.4.0)
57+
mini_portile2 (2.5.1)
5858
minitest (5.14.2)
59-
nokogiri (1.10.10)
60-
mini_portile2 (~> 2.4.0)
59+
nokogiri (1.11.3)
60+
mini_portile2 (~> 2.5.0)
61+
racc (~> 1.4)
6162
optimist (3.0.1)
6263
parallel (1.19.2)
6364
parser (2.7.1.4)
@@ -70,6 +71,7 @@ GEM
7071
pry-byebug (3.9.0)
7172
byebug (~> 11.0)
7273
pry (~> 0.13.0)
74+
racc (1.5.2)
7375
rack (2.2.3)
7476
rack-test (1.1.0)
7577
rack (>= 1.0, < 3)
@@ -150,4 +152,4 @@ DEPENDENCIES
150152
warnings_logger
151153

152154
BUNDLED WITH
153-
2.1.4
155+
2.2.17

‎gemfiles/rails_6_0_rspec_gte_3_10.gemfile.lock‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,10 @@ GEM
5353
crass (~> 1.0.2)
5454
nokogiri (>= 1.5.9)
5555
method_source (1.0.0)
56+
mini_portile2 (2.5.1)
5657
minitest (5.14.2)
57-
nokogiri (1.11.1-x86_64-darwin)
58+
nokogiri (1.11.1)
59+
mini_portile2 (~> 2.5.0)
5860
racc (~> 1.4)
5961
optimist (3.0.1)
6062
parallel (1.19.2)
@@ -150,4 +152,4 @@ DEPENDENCIES
150152
warnings_logger
151153

152154
BUNDLED WITH
153-
2.1.4
155+
2.2.17

0 commit comments

Comments
 (0)