Merge pull request #409 from ShawnJeffersonWang/master

tomasaschan · web-flow · commit 8a6c85f2ae48 · 2025-06-01T11:27:42.000+02:00
fix: correct argument length check in FlagSet.Parse
diff --git a/flag.go b/flag.go
@@ -1156,7 +1156,7 @@ func (f *FlagSet) Parse(arguments []string) error {
 	}
 	f.parsed = true
 
-	if len(arguments) < 0 {
+	if len(arguments) == 0 {
 		return nil
 	}
 
diff --git a/flag_test.go b/flag_test.go
@@ -100,6 +100,12 @@ func TestEverything(t *testing.T) {
 	}
 }
 
+func TestNoArgument(t *testing.T) {
+	if GetCommandLine().Parse([]string{}) != nil {
+		t.Error("parse failed for empty argument list")
+	}
+}
+
 func TestUsage(t *testing.T) {
 	called := false
 	ResetForTesting(func() { called = true })

Original file line number	Diff line number	Diff line change
`@@ -1156,7 +1156,7 @@ func (f *FlagSet) Parse(arguments []string) error {`
`1156`	`1156`	`}`
`1157`	`1157`	`f.parsed = true`
`1158`	`1158`
`1159`		`- if len(arguments) < 0 {`
	`1159`	`+ if len(arguments) == 0 {`
`1160`	`1160`	`return nil`
`1161`	`1161`	`}`
`1162`	`1162`
Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,12 @@ func TestEverything(t *testing.T) {`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`
	`103`	`+func TestNoArgument(t *testing.T) {`
	`104`	`+ if GetCommandLine().Parse([]string{}) != nil {`
	`105`	`+ t.Error("parse failed for empty argument list")`
	`106`	`+ }`
	`107`	`+}`
	`108`	`+`
`103`	`109`	`func TestUsage(t *testing.T) {`
`104`	`110`	`called := false`
`105`	`111`	`ResetForTesting(func() { called = true })`