WIP

Author: FrankRay78

src/Spectre.Console.Cli/Help/HelpProvider.cs

@@ -32,7 +32,7 @@ public class HelpProvider : IHelpProvider
     /// <remarks>
     /// Useful for unit testing different styling of the same help text.
     /// </remarks>
-    protected virtual bool RenderMarkupInline { get; }
+    protected virtual bool RenderMarkupInline { get; } = false;
 
     private sealed class HelpArgument
     {
@@ -115,8 +115,7 @@ public HelpProvider(ICommandAppSettings settings)
         this.ShowOptionDefaultValues = settings.ShowOptionDefaultValues;
         this.MaximumIndirectExamples = settings.MaximumIndirectExamples;
         this.TrimTrailingPeriod = settings.TrimTrailingPeriod;
-        this.RenderMarkupInline = settings.RenderMarkupInline;
-        this.helpStyles = settings.HelpProviderStyles;
+        this.helpStyles = settings.HelpProviderStyles ?? HelpProviderStyle.Default;
 
         resources = new HelpProviderResources(settings.Culture);
     }

src/Spectre.Console.Cli/ICommandAppSettings.cs

@@ -41,18 +41,10 @@ public interface ICommandAppSettings
     /// </summary>
     bool TrimTrailingPeriod { get; set; }
 
-    /// <summary>
-    /// Gets or sets a value indicating whether to emit the markup styles, inline, when rendering the help text.
-    /// </summary>
-    /// <remarks>
-    /// Useful for unit testing different styling of the same help text.
-    /// </remarks>
-    bool RenderMarkupInline { get; set; }
-
     /// <summary>
     /// Gets or sets the styles to used when rendering the help text.
     /// </summary>
-    HelpProviderStyle HelpProviderStyles { get; set; }
+    HelpProviderStyle? HelpProviderStyles { get; set; }
 
     /// <summary>
     /// Gets or sets the <see cref="IAnsiConsole"/>.

src/Spectre.Console.Cli/Internal/Configuration/CommandAppSettings.cs

@@ -15,8 +15,7 @@ internal sealed class CommandAppSettings : ICommandAppSettings
     public bool PropagateExceptions { get; set; }
     public bool ValidateExamples { get; set; }
     public bool TrimTrailingPeriod { get; set; }
-    public bool RenderMarkupInline { get; set; }
-    public HelpProviderStyle HelpProviderStyles { get; set; }
+    public HelpProviderStyle? HelpProviderStyles { get; set; }
     public bool StrictParsing { get; set; }
     public bool ConvertFlagsToRemainingArguments { get; set; }
 
@@ -32,7 +31,6 @@ public CommandAppSettings(ITypeRegistrar registrar)
         ShowOptionDefaultValues = true;
         MaximumIndirectExamples = 5;
         TrimTrailingPeriod = true;
-        RenderMarkupInline = false;
         HelpProviderStyles = HelpProviderStyle.Default;
         ConvertFlagsToRemainingArguments = false;
     }

test/Spectre.Console.Cli.Tests/Data/Help/NoStylesHelpProvider.cs

@@ -0,0 +1,11 @@
+namespace Spectre.Console.Cli.Tests.Data.Help;
+
+internal class NoStylesHelpProvider : HelpProvider
+{
+    protected override bool RenderMarkupInline { get; } = true;
+
+    public NoStylesHelpProvider(ICommandAppSettings settings)
+        : base(settings)
+    {
+    }
+}

test/Spectre.Console.Cli.Tests/Unit/CommandAppTests.Help.cs

@@ -277,8 +277,9 @@ public Task Should_Output_Default_Command_And_Additional_Commands_When_Default_C
             fixture.SetDefaultCommand<LionCommand>();
             fixture.Configure(configurator =>
             {
+                configurator.Settings.PropagateExceptions = true;
                 configurator.AddExample("20", "--alive");
-                configurator.Settings.RenderMarkupInline = true;
+                configurator.SetHelpProvider<NoStylesHelpProvider>();
                 configurator.Settings.HelpProviderStyles = helpProviderStyle switch
                 {
                     "Default" => HelpProviderStyle.Default,