Skip to content

Commit 084e018

Browse files
committed
[aws][system] Add versioning to build images
1 parent 2ce6dbc commit 084e018

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

sebs/benchmark.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,10 +422,11 @@ def install_dependencies(self, output_dir):
422422
)
423423
else:
424424
repo_name = self._system_config.docker_repository()
425-
image_name = "build.{deployment}.{language}.{runtime}".format(
425+
image_name = "build.{deployment}.{language}.{runtime}-{version}".format(
426426
deployment=self._deployment_name,
427427
language=self.language_name,
428428
runtime=self.language_version,
429+
version=self._system_config.version(),
429430
)
430431
try:
431432
self._docker_client.images.get(repo_name + ":" + image_name)

sebs/config.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ def benchmark_base_images(
6767
architecture
6868
]
6969

70+
def version(self) -> str:
71+
return self._system_config["general"].get("SeBS_version", "unknown")
72+
7073
def benchmark_image_name(
7174
self,
7275
system: str,

tools/build_docker_images.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def build(image_type, system, language=None, version=None, version_name=None):
3838
if version:
3939
target += "." + version
4040
sebs_version = config["general"].get("SeBS_version", "unknown")
41-
target += "." + sebs_version
41+
target += "-" + sebs_version
4242

4343
# if we pass an integer, the build will fail with 'connection reset by peer'
4444
buildargs = {
@@ -65,7 +65,7 @@ def build(image_type, system, language=None, version=None, version_name=None):
6565
def build_language(system, language, language_config):
6666
configs = []
6767
if "base_images" in language_config:
68-
for version, base_image in language_config["base_images"].items():
68+
for version, base_image in language_config["base_images"]["x64"].items():
6969
if args.language_version is not None and args.language_version == version:
7070
configs.append([version, base_image])
7171
elif args.language_version is None:

0 commit comments

Comments
 (0)