Skip to content

Commit 244c71a

Browse files
authored
Merge pull request #66 from Jamesking56/patch-1
Remove PWA category
2 parents 11b6c1b + 0e1ce37 commit 244c71a

4 files changed

Lines changed: 1 addition & 5 deletions

File tree

src/Enums/Category.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@ enum Category: string
1212
case Accessibility = 'accessibility';
1313
case BestPractices = 'best-practices';
1414
case Seo = 'seo';
15-
case ProgressiveWebApp = 'pwa';
1615
}

tests/IntegrationTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// remove "performance" as that key is sometimes empty
1313
// on GitHub actions due to less powerful hardware
1414
$expectedCategories = Arr::without(Category::values(), Category::Performance->value);
15-
$expectedCategories = Arr::without($expectedCategories, Category::ProgressiveWebApp->value);
1615

1716
expect($scores)->toHaveKeys($expectedCategories);
1817
});

tests/LighthouseResultTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
'accessibility' => 92,
2222
'best-practices' => 100,
2323
'seo' => 91,
24-
'pwa' => 30,
2524
]);
2625
});
2726

@@ -35,7 +34,6 @@
3534
'accessibility' => 92,
3635
'best-practices' => 100,
3736
'seo' => 91,
38-
'pwa' => 30,
3937
]);
4038
});
4139

tests/__snapshots__/LighthouseTest__it_will_use_the_default_config_by_default__1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ chromeOptions:
33
chromeFlags: ['--headless']
44
lighthouseConfig:
55
extends: 'lighthouse:default'
6-
settings: { onlyCategories: [performance, accessibility, best-practices, seo, pwa], formFactor: desktop, output: [json, html], disableNetworkThrottling: true, disableCpuThrottling: true, throttlingMethod: provided, screenEmulation: { disabled: true } }
6+
settings: { onlyCategories: [performance, accessibility, best-practices, seo], formFactor: desktop, output: [json, html], disableNetworkThrottling: true, disableCpuThrottling: true, throttlingMethod: provided, screenEmulation: { disabled: true } }
77
timeout: 59300
88
maxWaitForLoad: null

0 commit comments

Comments
 (0)