[jest] disallow invalid describe calls (elastic#41378)

* [jest] disallow invalid describe calls

* correct other describe calls

* remove unnecessary glob

* cast decribe names to strings

* remove new async describe function

# Conflicts:
#	test/functional/apps/dashboard/dashboard_filtering.js
#	x-pack/legacy/plugins/index_management/__jest__/client_integration/home.test.ts
#	x-pack/legacy/plugins/reporting/server/usage/get_reporting_usage_collector.test.js
#	x-pack/test/functional/apps/uptime/monitor.ts
#	x-pack/test_utils/jest/integration_tests/example_integration.test.ts

Author: Spencer

.eslintrc.js

@@ -361,6 +361,16 @@ module.exports = {
       },
     },
 
+    /**
+     * Jest specific rules
+     */
+    {
+      files: ['**/*.test.{js,ts,tsx}'],
+      rules: {
+        'jest/valid-describe': 'error',
+      },
+    },
+
     /**
      * APM overrides
      */

packages/kbn-pm/src/utils/projects.test.ts

@@ -224,7 +224,7 @@ describe('#topologicallyBatchProjects', () => {
     expect(expectedBatches).toMatchSnapshot();
   });
 
-  describe('batchByWorkspace = true', async () => {
+  describe('batchByWorkspace = true', () => {
     test('batches projects topologically based on their project dependencies and workspaces', async () => {
       const batches = topologicallyBatchProjects(projects, graph, { batchByWorkspace: true });
 

packages/kbn-ui-framework/src/components/button/button.test.js

@@ -56,7 +56,7 @@ describe('KuiButton', () => {
   describe('Props', () => {
     describe('buttonType', () => {
       BUTTON_TYPES.forEach(buttonType => {
-        describe(buttonType, () => {
+        describe(`${buttonType}`, () => {
           test(`renders the ${buttonType} class`, () => {
             const $button = render(
               <KuiButton

packages/kbn-ui-framework/src/components/button/button_icon/button_icon.test.js

@@ -42,7 +42,7 @@ describe('KuiButtonIcon', () => {
   describe('Props', () => {
     describe('type', () => {
       ICON_TYPES.forEach(type => {
-        describe(type, () => {
+        describe(`${type}`, () => {
           test(`renders the ${type} class`, () => {
             const $buttonIcon = render(<KuiButtonIcon type={type} />);
             expect($buttonIcon).toMatchSnapshot();

packages/kbn-ui-framework/src/components/button/link_button.test.js

@@ -57,7 +57,7 @@ describe('KuiLinkButton', () => {
   describe('Props', () => {
     describe('buttonType', () => {
       BUTTON_TYPES.forEach(buttonType => {
-        describe(buttonType, () => {
+        describe(`${buttonType}`, () => {
           test(`renders the ${buttonType} class`, () => {
             const $button = render(
               <KuiLinkButton

packages/kbn-ui-framework/src/components/button/submit_button.test.js

@@ -55,7 +55,7 @@ describe('KuiSubmitButton', () => {
   describe('Props', () => {
     describe('buttonType', () => {
       BUTTON_TYPES.forEach(buttonType => {
-        describe(buttonType, () => {
+        describe(`${buttonType}`, () => {
           test(`renders the ${buttonType} class`, () => {
             const $button = render(<KuiSubmitButton buttonType={buttonType} />);
             expect($button).toMatchSnapshot();

packages/kbn-ui-framework/src/components/collapse_button/collapse_button.test.js

@@ -31,7 +31,7 @@ describe('KuiCollapseButton', () => {
   describe('Props', () => {
     describe('direction', () => {
       DIRECTIONS.forEach(direction => {
-        describe(direction, () => {
+        describe(`${direction}`, () => {
           test(`renders the ${direction} class`, () => {
             const component = <KuiCollapseButton direction={direction} {...requiredProps}/>;
             expect(render(component)).toMatchSnapshot();

src/legacy/core_plugins/data/public/filter/filter_manager/filter_manager.test.ts

@@ -219,7 +219,7 @@ describe('filter_manager', () => {
     });
   });
 
-  describe('add filters', async () => {
+  describe('add filters', () => {
     test('app state should accept a single filter', async function() {
       updateSubscription = filterManager.getUpdates$().subscribe(updateListener);
       const f1 = getFilter(FilterStateStore.APP_STATE, false, false, 'age', 34);
@@ -535,7 +535,7 @@ describe('filter_manager', () => {
     });
   });
 
-  describe('remove filters', async () => {
+  describe('remove filters', () => {
     test('remove on empty should do nothing and not fire events', async () => {
       updateSubscription = filterManager.getUpdates$().subscribe(updateListener);
       await filterManager.removeAll();

src/legacy/ui/public/courier/fetch/request/serialize_fetch_params/serialize_fetch_params.test.js

@@ -81,7 +81,7 @@ describe('headers', () => {
     return JSON.parse(requestParts[0]);
   };
 
-  describe('search request preference', async () => {
+  describe('search request preference', () => {
     test('should be set to sessionId when courier:setRequestPreference is "sessionId"', async () => {
       const config = {
         get: () => {

src/legacy/ui/public/kfetch/kfetch.test.ts

@@ -133,7 +133,7 @@ describe('kfetch', () => {
     }
   });
 
-  describe('when throwing response error (KFetchError)', async () => {
+  describe('when throwing response error (KFetchError)', () => {
     let error: KFetchError;
     beforeEach(async () => {
       fetchMock.get('*', { status: 404, body: { foo: 'bar' } });
@@ -348,7 +348,7 @@ describe('kfetch', () => {
     });
   });
 
-  describe('when interceptors return synchronously', async () => {
+  describe('when interceptors return synchronously', () => {
     let resp: any;
     beforeEach(async () => {
       fetchMock.get('*', { foo: 'bar' });
@@ -381,7 +381,7 @@ describe('kfetch', () => {
     });
   });
 
-  describe('when interceptors return promise', async () => {
+  describe('when interceptors return promise', () => {
     let resp: any;
     beforeEach(async () => {
       fetchMock.get('*', { foo: 'bar' });