Skip to content

Implement link matcher priorities #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 2 commits into from
Mar 2, 2017
Merged

Implement link matcher priorities #577

Tyriar merged 2 commits into from
Mar 2, 2017

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 2, 2017

Fixes #549

@Tyriar Tyriar added this to the 2.4.0 milestone Mar 2, 2017
@Tyriar Tyriar self-assigned this Mar 2, 2017
@Tyriar Tyriar requested a review from parisk March 2, 2017 19:26
@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage increased (+0.3%) to 67.802% when pulling 7ac4f1a on Tyriar:549_link_priority into 670fb01 on sourcelair:master.

@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage increased (+0.3%) to 67.786% when pulling 78d5fc9 on Tyriar:549_link_priority into 670fb01 on sourcelair:master.

parisk
parisk approved these changes Mar 2, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tyriar Tyriar merged commit 8693d06 into xtermjs:master Mar 2, 2017
@Tyriar Tyriar deleted the 549_link_priority branch March 2, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Tyriar @coveralls @parisk