Skip to content

Commit 70099b4

Browse files
committed
Revert "Refactored mock_tests/ folder"
This reverts commit 06edeb9.
1 parent d436281 commit 70099b4

19 files changed

Lines changed: 61 additions & 40 deletions

tests/mock_tests/Makefile.am

Lines changed: 41 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ TESTS = tests tests_intfmgrd tests_portsyncd
99
noinst_PROGRAMS = tests tests_intfmgrd tests_portsyncd
1010

1111
LDADD_SAI = -lsaimeta -lsaimetadata -lsaivs -lsairedis
12-
LDADD_COMMON = -lnl-genl-3 -lhiredis -lswsscommon -lgtest -lgtest_main -lzmq -lnl-3 -lnl-route-3 -lpthread
1312

1413
if DEBUG
1514
DBGFLAGS = -ggdb -DDEBUG
@@ -20,21 +19,9 @@ endif
2019
CFLAGS_GTEST =
2120
LDADD_GTEST = -L/usr/src/gtest
2221

23-
mock_swsscommon_SOURCES = common/mock_shell_command.cpp \
24-
common/mock_redisreply.cpp \
25-
common/mock_dbconnector.cpp \
26-
common/mock_hiredis.cpp \
27-
common/mock_table.cpp \
28-
common/mock_consumerstatetable.cpp
29-
30-
mock_swss_SOURCES = common/mock_orchagent_main.cpp \
31-
common/fake_response_publisher.cpp
32-
33-
mock_sai_SOURCES = common/ut_saihelper.cpp
34-
3522
## Orchagent Unit Tests
3623

37-
tests_INCLUDES = -I $(FLEX_CTR_DIR) -I $(DEBUG_CTR_DIR) -I $(top_srcdir)/lib -I$(top_srcdir)/cfgmgr -I$(top_srcdir)/orchagent -Iincludes
24+
tests_INCLUDES = -I $(FLEX_CTR_DIR) -I $(DEBUG_CTR_DIR) -I $(top_srcdir)/lib -I$(top_srcdir)/cfgmgr -I$(top_srcdir)/orchagent
3825

3926
tests_SOURCES = aclorch_ut.cpp \
4027
portsorch_ut.cpp \
@@ -47,12 +34,18 @@ tests_SOURCES = aclorch_ut.cpp \
4734
saispy_ut.cpp \
4835
consumer_ut.cpp \
4936
sfloworh_ut.cpp \
37+
ut_saihelper.cpp \
38+
mock_orchagent_main.cpp \
39+
mock_dbconnector.cpp \
40+
mock_consumerstatetable.cpp \
41+
common/mock_shell_command.cpp \
42+
mock_table.cpp \
43+
mock_hiredis.cpp \
44+
mock_redisreply.cpp \
5045
bulker_ut.cpp \
5146
portmgr_ut.cpp \
47+
fake_response_publisher.cpp \
5248
swssnet_ut.cpp \
53-
$(mock_swsscommon_SOURCES) \
54-
$(mock_sai_SOURCES) \
55-
$(mock_swss_SOURCES) \
5649
flowcounterrouteorch_ut.cpp \
5750
$(top_srcdir)/lib/gearboxutils.cpp \
5851
$(top_srcdir)/lib/subintf.cpp \
@@ -129,31 +122,44 @@ tests_SOURCES += $(P4_ORCH_DIR)/p4orch.cpp \
129122

130123
tests_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_SAI)
131124
tests_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_SAI) $(tests_INCLUDES)
132-
tests_LDADD = $(LDADD_GTEST) $(LDADD_SAI) $(LDADD_COMMON)
133-
134-
## intfmgrd unit tests
135-
136-
tests_intfmgrd_SOURCES = intfmgrd/add_ipv6_prefix_ut.cpp \
137-
$(top_srcdir)/cfgmgr/intfmgr.cpp \
138-
$(top_srcdir)/lib/subintf.cpp \
139-
$(top_srcdir)/orchagent/orch.cpp \
140-
$(top_srcdir)/orchagent/request_parser.cpp \
141-
$(mock_swsscommon_SOURCES) \
142-
$(mock_swss_SOURCES)
143-
144-
tests_intfmgrd_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_SAI)
145-
tests_intfmgrd_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_SAI) $(tests_INCLUDES)
146-
tests_intfmgrd_LDADD = $(LDADD_GTEST) $(LDADD_SAI) $(LDADD_COMMON)
125+
tests_LDADD = $(LDADD_GTEST) $(LDADD_SAI) -lnl-genl-3 -lhiredis -lhiredis -lpthread \
126+
-lswsscommon -lswsscommon -lgtest -lgtest_main -lzmq -lnl-3 -lnl-route-3
147127

148128
## portsyncd unit tests
149129

150130
tests_portsyncd_SOURCES = portsyncd/portsyncd_ut.cpp \
151131
$(top_srcdir)/portsyncd/linksync.cpp \
152132
$(top_srcdir)/portsyncd/portsyncd_helper.cpp \
153-
$(mock_swsscommon_SOURCES)
133+
mock_dbconnector.cpp \
134+
common/mock_shell_command.cpp \
135+
mock_table.cpp \
136+
mock_hiredis.cpp \
137+
mock_redisreply.cpp
154138

155-
tests_portsyncd_INCLUDES = -I $(top_srcdir)/lib -I$(top_srcdir)/portsyncd -I$(top_srcdir)/cfgmgr -Iincludes
139+
tests_portsyncd_INCLUDES = -I $(top_srcdir)/portsyncd -I $(top_srcdir)/cfgmgr
156140
tests_portsyncd_CXXFLAGS = -Wl,-wrap,if_nameindex -Wl,-wrap,if_freenameindex
157141
tests_portsyncd_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST)
158142
tests_portsyncd_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(tests_portsyncd_INCLUDES)
159-
tests_portsyncd_LDADD = $(LDADD_GTEST) $(LDADD_COMMON)
143+
tests_portsyncd_LDADD = $(LDADD_GTEST) -lnl-genl-3 -lhiredis -lhiredis \
144+
-lswsscommon -lswsscommon -lgtest -lgtest_main -lnl-3 -lnl-route-3 -lpthread
145+
146+
## intfmgrd unit tests
147+
148+
tests_intfmgrd_SOURCES = intfmgrd/add_ipv6_prefix_ut.cpp \
149+
$(top_srcdir)/cfgmgr/intfmgr.cpp \
150+
$(top_srcdir)/lib/subintf.cpp \
151+
$(top_srcdir)/orchagent/orch.cpp \
152+
$(top_srcdir)/orchagent/request_parser.cpp \
153+
mock_orchagent_main.cpp \
154+
mock_dbconnector.cpp \
155+
mock_table.cpp \
156+
mock_hiredis.cpp \
157+
fake_response_publisher.cpp \
158+
mock_redisreply.cpp \
159+
common/mock_shell_command.cpp
160+
161+
tests_intfmgrd_INCLUDES = $(tests_INCLUDES) -I$(top_srcdir)/cfgmgr -I$(top_srcdir)/lib
162+
tests_intfmgrd_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_SAI)
163+
tests_intfmgrd_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_SAI) $(tests_intfmgrd_INCLUDES)
164+
tests_intfmgrd_LDADD = $(LDADD_GTEST) $(LDADD_SAI) -lnl-genl-3 -lhiredis -lhiredis \
165+
-lswsscommon -lswsscommon -lgtest -lgtest_main -lzmq -lnl-3 -lnl-route-3 -lpthread
File renamed without changes.

tests/mock_tests/fdborch/flush_syncd_notif_ut.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#include "ut_helper.h"
2-
#include "mock_orchagent_main.h"
3-
#include "mock_table.h"
1+
#include "../ut_helper.h"
2+
#include "../mock_orchagent_main.h"
3+
#include "../mock_table.h"
44
#include "port.h"
55
#define private public // Need to modify internal cache
66
#include "portsorch.h"

tests/mock_tests/intfmgrd/add_ipv6_prefix_ut.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#include <fstream>
44
#include <unistd.h>
55
#include <sys/stat.h>
6-
#include "mock_table.h"
6+
#include "../mock_table.h"
77
#include "warm_restart.h"
88
#define private public
99
#include "intfmgr.h"
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)