Revert "[nvidia] Skip SAI discovery on ports (#1416)" (#1595)

This reverts commit 0f3b34e.

PR #1559 is merged, so we can revert skip on nvidia.
Not having separate code path is good for unit testing and general maintainability of the code.

Author: stepanblyschak

syncd/Makefile.am

@@ -83,10 +83,6 @@ if SONIC_ASIC_PLATFORM_BROADCOM
 libSyncd_a_CXXFLAGS += -DMDIO_ACCESS_USE_NPU
 endif
 
-if SONIC_ASIC_PLATFORM_MELLANOX
-libSyncd_a_CPPFLAGS += -DSKIP_SAI_PORT_DISCOVERY
-endif
-
 libSyncdRequestShutdown_a_SOURCES = \
 									RequestShutdown.cpp \
 									RequestShutdownCommandLineOptions.cpp \

syncd/SaiDiscovery.cpp

@@ -114,13 +114,6 @@ void SaiDiscovery::discover(
         discovered.insert(rid);
     }
 
-#ifdef SKIP_SAI_PORT_DISCOVERY
-    if (ot == SAI_OBJECT_TYPE_PORT)
-    {
-        return;
-    }
-#endif
-
     const sai_object_type_info_t *info = sai_metadata_get_object_type_info(ot);
 
     /*

syncd/Syncd.cpp

@@ -233,10 +233,6 @@ Syncd::Syncd(
 
     m_breakConfig = BreakConfigParser::parseBreakConfig(m_commandLineOptions->m_breakConfig);
 
-#ifdef SKIP_SAI_PORT_DISCOVERY
-    SWSS_LOG_WARN("SAI discovery is skipped on ports");
-#endif
-
     SWSS_LOG_NOTICE("syncd started");
 }